Skip to content

Commit 5ff454f

Browse files
committed
Rename types
1 parent 81d30f3 commit 5ff454f

File tree

7 files changed

+19
-19
lines changed

7 files changed

+19
-19
lines changed

src/ConfigEditor.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import React from 'react';
22
import { DataSourceHttpSettings } from '@grafana/ui';
33
import { DataSourcePluginOptionsEditorProps } from '@grafana/data';
4-
import { MyDataSourceOptions } from './types';
4+
import { JsonApiDataSourceOptions } from './types';
55
import { ConfigSettings } from './ConfigSettings';
66

7-
interface Props extends DataSourcePluginOptionsEditorProps<MyDataSourceOptions> {}
7+
interface Props extends DataSourcePluginOptionsEditorProps<JsonApiDataSourceOptions> {}
88

99
export const ConfigEditor: React.FC<Props> = ({ options, onOptionsChange }) => {
1010
return (

src/ConfigSettings.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ import React, { ChangeEvent } from 'react';
33
import { DataSourcePluginOptionsEditorProps } from '@grafana/data';
44

55
import { Field, Input } from '@grafana/ui';
6-
import { MyDataSourceOptions } from './types';
6+
import { JsonApiDataSourceOptions } from './types';
77
import {} from '@emotion/core';
88

9-
type Props = Pick<DataSourcePluginOptionsEditorProps<MyDataSourceOptions>, 'options' | 'onOptionsChange'>;
9+
type Props = Pick<DataSourcePluginOptionsEditorProps<JsonApiDataSourceOptions>, 'options' | 'onOptionsChange'>;
1010

1111
export const ConfigSettings: React.FC<Props> = ({ options, onOptionsChange }) => {
1212
const onChange = (e: ChangeEvent<HTMLInputElement>) => {

src/DataSource.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ import {
1313
} from '@grafana/data';
1414

1515
import API from './api';
16-
import { JsonApiQuery, MyVariableQuery, MyDataSourceOptions } from './types';
16+
import { JsonApiQuery, JsonApiVariableQuery, JsonApiDataSourceOptions } from './types';
1717

18-
export class DataSource extends DataSourceApi<JsonApiQuery, MyDataSourceOptions> {
18+
export class DataSource extends DataSourceApi<JsonApiQuery, JsonApiDataSourceOptions> {
1919
api: API;
2020
queryParams: string;
2121

22-
constructor(instanceSettings: DataSourceInstanceSettings<MyDataSourceOptions>) {
22+
constructor(instanceSettings: DataSourceInstanceSettings<JsonApiDataSourceOptions>) {
2323
super(instanceSettings);
2424
this.api = new API(instanceSettings.url!);
2525
this.queryParams = instanceSettings.jsonData.queryParams || '';
@@ -64,7 +64,7 @@ export class DataSource extends DataSourceApi<JsonApiQuery, MyDataSourceOptions>
6464
*
6565
* @param query
6666
*/
67-
async metricFindQuery?(query: MyVariableQuery): Promise<MetricFindValue[]> {
67+
async metricFindQuery?(query: JsonApiVariableQuery): Promise<MetricFindValue[]> {
6868
if (!query.jsonPath) {
6969
return [];
7070
}

src/QueryEditor.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ import React, { ChangeEvent } from 'react';
33
import { Icon, InlineFormLabel, Segment } from '@grafana/ui';
44
import { QueryEditorProps } from '@grafana/data';
55
import { DataSource } from './DataSource';
6-
import { MyDataSourceOptions, JsonApiQuery, defaultQuery } from './types';
6+
import { JsonApiDataSourceOptions, JsonApiQuery, defaultQuery } from './types';
77
import { JsonPathQueryField } from './JsonPathQueryField';
88
import { cx } from 'emotion';
99

10-
type Props = QueryEditorProps<DataSource, JsonApiQuery, MyDataSourceOptions>;
10+
type Props = QueryEditorProps<DataSource, JsonApiQuery, JsonApiDataSourceOptions>;
1111

1212
export const QueryEditor: React.FC<Props> = ({ onRunQuery, onChange, query }) => {
1313
const { fields } = defaults(query, defaultQuery);

src/VariableQueryEditor.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
import React, { useState } from 'react';
2-
import { MyVariableQuery } from './types';
2+
import { JsonApiVariableQuery } from './types';
33
import { InlineFormLabel } from '@grafana/ui';
44
import { JsonPathQueryField } from './JsonPathQueryField';
55

66
interface VariableQueryProps {
7-
query: MyVariableQuery;
8-
onChange: (query: MyVariableQuery, definition: string) => void;
7+
query: JsonApiVariableQuery;
8+
onChange: (query: JsonApiVariableQuery, definition: string) => void;
99
}
1010

1111
export const VariableQueryEditor: React.FC<VariableQueryProps> = ({ onChange, query }) => {
12-
const [state, setState] = useState<MyVariableQuery>(query);
12+
const [state, setState] = useState<JsonApiVariableQuery>(query);
1313

1414
const saveQuery = () => {
1515
onChange(state, state.jsonPath);

src/module.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ import { DataSource } from './DataSource';
33
import { ConfigEditor } from './ConfigEditor';
44
import { QueryEditor } from './QueryEditor';
55
import { VariableQueryEditor } from './VariableQueryEditor';
6-
import { JsonApiQuery, MyDataSourceOptions } from './types';
6+
import { JsonApiQuery, JsonApiDataSourceOptions } from './types';
77

8-
export const plugin = new DataSourcePlugin<DataSource, JsonApiQuery, MyDataSourceOptions>(DataSource)
8+
export const plugin = new DataSourcePlugin<DataSource, JsonApiQuery, JsonApiDataSourceOptions>(DataSource)
99
.setConfigEditor(ConfigEditor)
1010
.setQueryEditor(QueryEditor)
1111
.setVariableQueryEditor(VariableQueryEditor);

src/types.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export interface JsonApiQuery extends DataQuery {
1010
cacheDurationSeconds: number;
1111
}
1212

13-
export interface MyVariableQuery extends DataQuery {
13+
export interface JsonApiVariableQuery extends DataQuery {
1414
jsonPath: string;
1515
}
1616

@@ -19,8 +19,8 @@ export const defaultQuery: Partial<JsonApiQuery> = {
1919
cacheDurationSeconds: 300,
2020
};
2121

22-
export interface MyDataSourceOptions extends DataSourceJsonData {
22+
export interface JsonApiDataSourceOptions extends DataSourceJsonData {
2323
queryParams?: string;
2424
}
2525

26-
export interface MySecureJsonData {}
26+
export interface JsonApiSecureJsonData {}

0 commit comments

Comments
 (0)