Using JSON.stringify instead of toString for object types in parseValue (#111)

* Using JSON.stringify instead of toString for object types in parseValue

* Running prettier

Co-authored-by: Totalus <Totalus@users.noreply.github.com>
Co-authored-by: Marcus Olsson <marcus.olsson@hey.com>

Author: Totalus

src/parseValues.test.ts

@@ -70,3 +70,8 @@ test('parse nullable booleans', () => {
   expect(parseValues(values, FieldType.string)).toStrictEqual([null, 'true', 'false']);
   expect(() => parseValues(values, FieldType.time)).toThrow();
 });
+
+test('parse objects', () => {
+  const values = [[1, 2, 3], { '123': 123 }, null];
+  expect(parseValues(values, FieldType.string)).toStrictEqual(['[1,2,3]', '{"123":123}', null]);
+});

src/parseValues.ts

@@ -10,16 +10,16 @@ export const parseValues = (values: any[], type: FieldType): any[] => {
       // For time field, values are expected to be numbers representing a Unix
       // epoch in milliseconds.
 
-      if (values.filter((_) => _).every((value) => typeof value === 'string')) {
-        return values.map((_) => (_ !== null ? dayjs(_).valueOf() : _));
+      if (values.filter(_ => _).every(value => typeof value === 'string')) {
+        return values.map(_ => (_ !== null ? dayjs(_).valueOf() : _));
       }
 
-      if (values.filter((_) => _).every((value) => typeof value === 'number')) {
+      if (values.filter(_ => _).every(value => typeof value === 'number')) {
         const ms = 1_000_000_000_000;
 
         // If there are no "big" numbers, assume seconds.
-        if (values.filter((_) => _).every((_) => _ < ms)) {
-          return values.map((_) => (_ !== null ? _ * 1000.0 : _));
+        if (values.filter(_ => _).every(_ => _ < ms)) {
+          return values.map(_ => (_ !== null ? _ * 1000.0 : _));
         }
 
         // ... otherwise assume milliseconds.
@@ -28,13 +28,19 @@ export const parseValues = (values: any[], type: FieldType): any[] => {
 
       throw new Error('Unsupported time property');
     case FieldType.string:
-      return values.every((_) => typeof _ === 'string') ? values : values.map((_) => (_ !== null ? _.toString() : _));
+      return values.every(_ => typeof _ === 'string')
+        ? values
+        : values.map(_ => {
+            if (_ === null) return _;
+            else if (typeof _ === 'object') return JSON.stringify(_);
+            else return _.toString();
+          });
     case FieldType.number:
-      return values.every((_) => typeof _ === 'number') ? values : values.map((_) => (_ !== null ? parseFloat(_) : _));
+      return values.every(_ => typeof _ === 'number') ? values : values.map(_ => (_ !== null ? parseFloat(_) : _));
     case FieldType.boolean:
-      return values.every((_) => typeof _ === 'boolean')
+      return values.every(_ => typeof _ === 'boolean')
         ? values
-        : values.map((_) => {
+        : values.map(_ => {
             if (_ === null) {
               return _;
             }