Skip to content

Commit 9eced2a

Browse files
committed
Fix some more tests
1 parent 0555b07 commit 9eced2a

File tree

2 files changed

+8
-28
lines changed

2 files changed

+8
-28
lines changed

e2e/annotation-editor.spec.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,8 @@ test.describe('Prometheus annotation query editor', () => {
1111
}) => {
1212
const ds = await readProvisionedDataSource<DataSourcePluginOptionsEditorProps<PromOptions>>({ fileName: 'datasources.yml' });
1313

14-
await page.getByTestId('data-testid Select a data source').click();
15-
16-
await page.getByTestId('data-testid Select a data source').fill(ds.name);
17-
18-
await page.getByRole('button', { name: `${ds.name}` }).click();
19-
14+
await annotationEditPage.datasource.set(ds.name);
15+
2016
await expect(annotationEditPage
2117
.getByGrafanaSelector(selectors.components.DataSource.Prometheus.queryEditor.code.queryField)).toBeVisible();
2218
});

e2e/query-editor.spec.ts

Lines changed: 6 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -230,17 +230,9 @@ test.describe('Prometheus query editor', () => {
230230
explorePage,
231231
page,
232232
}) => {
233-
// const dsDefaultEditorBuilder = await readProvisionedDataSource<DataSourcePluginOptionsEditorProps<PromOptions>>({ fileName: 'datasources.yml' });
234-
235-
await explorePage.goto();
233+
const ds = await readProvisionedDataSource<DataSourcePluginOptionsEditorProps<PromOptions>>({ fileName: 'datasources.yml' });
236234

237-
// await explorePage.datasource.set(dsDefaultEditorBuilder.name);
238-
239-
await page.getByTestId('data-testid Select a data source').click();
240-
241-
await page.getByTestId('data-testid Select a data source').fill('Amazon Managed Service for Prometheus');
242-
243-
await page.getByRole('button', { name: 'Amazon Managed Service for Prometheus' }).click();
235+
await explorePage.datasource.set(ds.name);
244236

245237
await explorePage
246238
.getByGrafanaSelector(selectors.components.DataSource.Prometheus.queryEditor.builder.metricSelect)
@@ -264,17 +256,9 @@ test.describe('Prometheus query editor', () => {
264256
explorePage,
265257
page,
266258
}) => {
267-
// const dsDefaultEditorBuilder = await readProvisionedDataSource<DataSourcePluginOptionsEditorProps<PromOptions>>({ fileName: 'datasources.yml' });
259+
const ds = await readProvisionedDataSource<DataSourcePluginOptionsEditorProps<PromOptions>>({ fileName: 'datasources.yml' });
268260

269-
await explorePage.goto();
270-
271-
// await explorePage.datasource.set(dsDefaultEditorBuilder.name);
272-
273-
await page.getByTestId('data-testid Select a data source').click();
274-
275-
await page.getByTestId('data-testid Select a data source').fill('Amazon Managed Service for Prometheus');
276-
277-
await page.getByRole('button', { name: 'Amazon Managed Service for Prometheus' }).click();
261+
await explorePage.datasource.set(ds.name);
278262

279263
await explorePage
280264
.getByGrafanaSelector(selectors.components.DataSource.Prometheus.queryEditor.builder.metricSelect)
@@ -381,9 +365,9 @@ test.describe('Prometheus query editor', () => {
381365
readProvisionedDataSource,
382366
explorePage,
383367
}) => {
384-
// const dsDefaultEditorBuilder = await readProvisionedDataSource<DataSourcePluginOptionsEditorProps<PromOptions>>({ fileName: 'datasources.yml' });
368+
const ds = await readProvisionedDataSource<DataSourcePluginOptionsEditorProps<PromOptions>>({ fileName: 'datasources.yml' });
385369

386-
await explorePage.datasource.set('Amazon Managed Service for Prometheus');
370+
await explorePage.datasource.set(ds.name);
387371

388372
await explorePage
389373
.getByGrafanaSelector(selectors.components.DataSource.Prometheus.queryEditor.builder.metricSelect)

0 commit comments

Comments
 (0)