Skip to content

Commit 94f4f55

Browse files
authored
Update @grafana/plugin-e2e to v1.1.1 (#81)
* update dependencies once more * update plugin-e2e * fix e2e tests * update configuration.spec.ts
1 parent 24a0c91 commit 94f4f55

7 files changed

+175
-214
lines changed

cypress.json

Lines changed: 0 additions & 3 deletions
This file was deleted.

e2e/annotation-editor.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,6 @@ test.describe('Prometheus annotation query editor', () => {
1818
await page.getByRole('button', { name: `${ds.name} Prometheus` }).click();
1919

2020
await expect(annotationEditPage
21-
.getByTestIdOrAriaLabel(selectors.components.DataSource.Prometheus.queryEditor.code.queryField)).toBeVisible();
21+
.getByGrafanaSelector(selectors.components.DataSource.Prometheus.queryEditor.code.queryField)).toBeVisible();
2222
});
2323
});

e2e/configuration.spec.ts

Lines changed: 21 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -27,27 +27,27 @@ test.describe('Configuration tests', () => {
2727
}) => {
2828
const ds = await readProvisionedDataSource<DataSourcePluginOptionsEditorProps<PromOptions>>({ fileName: 'datasources.yml' });
2929
const configPage = await createDataSourceConfigPage({ type: ds.type });
30-
30+
3131
// connection settings
3232
await expect(configPage
33-
.getByTestIdOrAriaLabel(selectors.components.DataSource.Prometheus.configPage.connectionSettings)).toBeVisible();
33+
.getByGrafanaSelector(selectors.components.DataSource.Prometheus.configPage.connectionSettings)).toBeVisible();
3434

3535
// managed alerts
3636
await expect(
3737
page.locator(`#${selectors.components.DataSource.Prometheus.configPage.manageAlerts}`)
3838
).toBeVisible();
39-
39+
4040
// scrape interval
4141
await expect(configPage
42-
.getByTestIdOrAriaLabel(selectors.components.DataSource.Prometheus.configPage.scrapeInterval)).toBeVisible();
43-
42+
.getByGrafanaSelector(selectors.components.DataSource.Prometheus.configPage.scrapeInterval)).toBeVisible();
43+
4444
// query timeout
4545
await expect(configPage
46-
.getByTestIdOrAriaLabel(selectors.components.DataSource.Prometheus.configPage.queryTimeout)).toBeVisible();
46+
.getByGrafanaSelector(selectors.components.DataSource.Prometheus.configPage.queryTimeout)).toBeVisible();
4747

4848
// default editor
4949
await expect(configPage
50-
.getByTestIdOrAriaLabel(selectors.components.DataSource.Prometheus.configPage.defaultEditor)).toBeVisible();
50+
.getByGrafanaSelector(selectors.components.DataSource.Prometheus.configPage.defaultEditor)).toBeVisible();
5151

5252
// disable metric lookup
5353
await expect(
@@ -56,11 +56,11 @@ test.describe('Configuration tests', () => {
5656

5757
// prometheus type
5858
await expect(configPage
59-
.getByTestIdOrAriaLabel(selectors.components.DataSource.Prometheus.configPage.prometheusType)).toBeVisible();
59+
.getByGrafanaSelector(selectors.components.DataSource.Prometheus.configPage.prometheusType)).toBeVisible();
6060

6161
// cache level
6262
await expect(configPage
63-
.getByTestIdOrAriaLabel(selectors.components.DataSource.Prometheus.configPage.cacheLevel)).toBeVisible();
63+
.getByGrafanaSelector(selectors.components.DataSource.Prometheus.configPage.cacheLevel)).toBeVisible();
6464

6565
// incremental querying
6666
await expect(page.locator(`#${selectors.components.DataSource.Prometheus.configPage.incrementalQuerying}`)).toBeVisible();
@@ -70,11 +70,11 @@ test.describe('Configuration tests', () => {
7070

7171
// custom query parameters
7272
await expect(configPage
73-
.getByTestIdOrAriaLabel(selectors.components.DataSource.Prometheus.configPage.customQueryParameters)).toBeVisible();
73+
.getByGrafanaSelector(selectors.components.DataSource.Prometheus.configPage.customQueryParameters)).toBeVisible();
7474

7575
// http method
7676
await expect(configPage
77-
.getByTestIdOrAriaLabel(selectors.components.DataSource.Prometheus.configPage.httpMethod)).toBeVisible();
77+
.getByGrafanaSelector(selectors.components.DataSource.Prometheus.configPage.httpMethod)).toBeVisible();
7878
});
7979

8080
test('"Save & test" should be successful when configuration is valid', async ({
@@ -83,9 +83,9 @@ test.describe('Configuration tests', () => {
8383
}) => {
8484
const ds = await readProvisionedDataSource<DataSourcePluginOptionsEditorProps<PromOptions>>({ fileName: 'datasources.yml' });
8585
const configPage = await createDataSourceConfigPage({ type: ds.type });
86-
86+
8787
await configPage
88-
.getByTestIdOrAriaLabel(selectors.components.DataSource.Prometheus.configPage.connectionSettings)
88+
.getByGrafanaSelector(selectors.components.DataSource.Prometheus.configPage.connectionSettings)
8989
.fill(ds.url || '');
9090

9191
await expect(configPage.saveAndTest()).toBeOK();
@@ -101,63 +101,48 @@ test.describe('Configuration tests', () => {
101101
await expect(configPage).toHaveAlert('error', { hasText: 'empty url' });
102102
});
103103

104-
test('it should allow a user to add the version when the Prom type is selected',
104+
test('it should allow a user to add the version when the Prom type is selected',
105105
async ({
106106
createDataSourceConfigPage,
107-
readProvisionedDataSource,
107+
// readProvisionedDataSource,
108108
page,
109109
}) => {
110-
const ds = await readProvisionedDataSource<DataSourcePluginOptionsEditorProps<PromOptions>>({ fileName: 'datasources.yml' });
111-
112110
const configPage = await createDataSourceConfigPage({
113111
type: "grafana-prometheusamazon-datasource",
114112
name: DATA_SOURCE_NAME,
115113
});
116-
114+
117115
await expect(configPage
118-
.getByTestIdOrAriaLabel(
116+
.getByGrafanaSelector(
119117
selectors.components.DataSource.Prometheus.configPage.prometheusType
120118
)).toBeVisible();
121-
122119

123120
// open the select dropdown
124121
await page.getByLabel('Prometheus type').click();
125122

126123
// select a prometheus type
127124
await page.getByText('Cortex').click();
128-
125+
129126
// expect the version component to be displayed
130127
await expect(configPage
131-
.getByTestIdOrAriaLabel(
128+
.getByGrafanaSelector(
132129
selectors.components.DataSource.Prometheus.configPage.prometheusVersion
133130
)).toBeVisible();
134131
});
135132

136-
test('it should allow a user to select a query overlap window when incremental querying is selected',
133+
test('it should allow a user to select a query overlap window when incremental querying is selected',
137134
async ({
138135
createDataSourceConfigPage,
139136
page,
140137
}) => {
141-
// const ds = await readProvisionedDataSource<DataSourcePluginOptionsEditorProps<PromOptions>>({ fileName: 'datasources.yml' });
142-
143138
const configPage = await createDataSourceConfigPage({
144139
type: "grafana-prometheusamazon-datasource",
145140
name: DATA_SOURCE_NAME + "check",
146141
});
147-
148-
const incrementalQuerying = await page
149-
.locator(`#${selectors.components.DataSource.Prometheus.configPage.incrementalQuerying}`)
150-
151-
expect(incrementalQuerying).toBeVisible();
152142

153143
await page.getByLabel('Toggle switch').nth(3).setChecked(true);
154144

155-
expect(
156-
configPage
157-
.getByTestIdOrAriaLabel(
158-
selectors.components.DataSource.Prometheus.configPage.queryOverlapWindow
159-
)
160-
).toBeVisible();
145+
expect(configPage.getByGrafanaSelector(selectors.components.DataSource.Prometheus.configPage.queryOverlapWindow)).toBeVisible();
161146
});
162147

163148
// exemplars tested in exemplar.spec

0 commit comments

Comments
 (0)