remove automatic flavor and version detection

Author: bohandley

src/configuration/PromSettings.tsx

@@ -1,22 +1,16 @@
 import {
   DataSourcePluginOptionsEditorProps,
-  /* DataSourceSettings as DataSourceSettingsType, */
   onUpdateDatasourceJsonDataOptionChecked,
   SelectableValue,
   updateDatasourcePluginJsonDataOption,
 } from '@grafana/data';
 import { ConfigSubSection } from '@grafana/experimental';
-// import { config/*, getBackendSrv */} from '@grafana/runtime';
 import { InlineField, Input, Select, Switch, useTheme2 } from '@grafana/ui';
 import React, { SyntheticEvent, useState } from 'react';
-// import semver from 'semver/preload';
 
-
-// import { useUpdateDatasource } from '../../../../features/datasources/state';
-// import { PromApplication, PromBuildInfoResponse } from '../../../../types/unified-alerting-dto';
 import { QueryEditorMode } from '../querybuilder/shared/types';
 import { defaultPrometheusQueryOverlapWindow } from '../querycache/QueryCache';
-import { PromApplication, /*PromBuildInfoResponse,*/ PrometheusCacheLevel, PromOptions } from '../types';
+import { PromApplication, PrometheusCacheLevel, PromOptions } from '../types';
 
 import { docsTip, overhaulStyles, PROM_CONFIG_LABEL_WIDTH, validateInput } from './ConfigEditor';
 import { ExemplarsSettings } from './ExemplarsSettings';
@@ -57,108 +51,17 @@ export const DURATION_REGEX = /^$|^\d+(ms|[Mwdhmsy])$/;
 export const MULTIPLE_DURATION_REGEX = /(\d+)(.+)/;
 
 const durationError = 'Value is not valid, you can use number with time unit specifier: y, M, w, d, h, m, s';
-/**
- * Returns the closest version to what the user provided that we have in our PromFlavorVersions for the currently selected flavor
- * Bugs: It will only reject versions that are a major release apart, so Mimir 2.x might get selected for Prometheus 2.8 if the user selects an incorrect flavor
- * Advantages: We don't need to maintain a list of every possible version for each release
- *
- * This function will return the closest version from PromFlavorVersions that is equal or lower to the version argument
- */
-// const getVersionString = (version: string, flavor?: string): string | undefined => {
-//   if (!flavor || !PromFlavorVersions[flavor]) {
-//     return;
-//   }
-//   const flavorVersionValues = PromFlavorVersions[flavor];
-
-//   // As long as it's assured we're using versions which are sorted, we could just filter out the values greater than the target version, and then check the last element in the array
-//   const versionsLessThanOrEqual = flavorVersionValues
-//     ?.filter((el) => !!el.value && semver.lte(el.value, version))
-//     .map((el) => el.value);
-
-//   const closestVersion = versionsLessThanOrEqual[versionsLessThanOrEqual.length - 1];
-
-//   if (closestVersion) {
-//     const differenceBetweenActualAndClosest = semver.diff(closestVersion, version);
-
-//     // Only return versions if the target is close to the actual.
-//     if (['patch', 'prepatch', 'prerelease', null].includes(differenceBetweenActualAndClosest)) {
-//       return closestVersion;
-//     }
-//   }
-
-//   return;
-// };
-
-// const unableToDeterminePrometheusVersion = (error?: Error): void => {
-//   console.warn('Error fetching version from buildinfo API, must manually select version!', error);
-// };
-
-/**
- * I don't like the daisy chain of network requests, and that we have to save on behalf of the user, but currently
- * the backend doesn't allow for the prometheus client url to be passed in from the frontend, so we currently need to save it
- * to the database before consumption.
- *
- * Since the prometheus version fields are below the url field, we can expect users to populate this field before
- * hitting save and test at the bottom of the page. For this case we need to save the current fields before calling the
- * resource to auto-detect the version.
- *
- * @param options
- * @param onOptionsChange
- * @param onUpdate
- */
-// COMMENTING OUT UNTIL WE CAN FIGURE OUT HOW TO DO THIS OUTSIDE OF CORE
-// const setPrometheusVersion = (
-//   options: DataSourceSettingsType<PromOptions>,
-//   onOptionsChange: (options: DataSourceSettingsType<PromOptions>) => void,
-//   onUpdate: (dataSource: DataSourceSettingsType<PromOptions>) => Promise<DataSourceSettingsType<PromOptions>>
-// ) => {
-//   // This will save the current state of the form, as the url is needed for this API call to function
-//   onUpdate(options)
-//     .then((updatedOptions) => {
-//       getBackendSrv()
-//         .get(`/api/datasources/uid/${updatedOptions.uid}/resources/version-detect`)
-//         .then((rawResponse: PromBuildInfoResponse) => {
-//           const rawVersionStringFromApi = rawResponse.data?.version ?? '';
-//           if (rawVersionStringFromApi && semver.valid(rawVersionStringFromApi)) {
-//             const parsedVersion = getVersionString(rawVersionStringFromApi, updatedOptions.jsonData.prometheusType);
-//             // If we got a successful response, let's update the backend with the version right away if it's new
-//             if (parsedVersion) {
-//               onUpdate({
-//                 ...updatedOptions,
-//                 jsonData: {
-//                   ...updatedOptions.jsonData,
-//                   prometheusVersion: parsedVersion,
-//                 },
-//               }).then((updatedUpdatedOptions) => {
-//                 onOptionsChange(updatedUpdatedOptions);
-//               });
-//             }
-//           } else {
-//             unableToDeterminePrometheusVersion();
-//           }
-//         });
-//     })
-//     .catch((error) => {
-//       unableToDeterminePrometheusVersion(error);
-//     });
-// };
 
 export const PromSettings = (props: Props) => {
   const { options, onOptionsChange } = props;
 
-  // This update call is typed as void, but it returns a response which we need
-  // REMOVE UNTIL WE FIGURE OUT HOW TO DO THIS OUTSIDE OF CORE
-  // const onUpdate = useUpdateDatasource();
-
   // We are explicitly adding httpMethod so, it is correctly displayed in dropdown.
   // This way, it is more predictable for users.
   if (!options.jsonData.httpMethod) {
     options.jsonData.httpMethod = 'POST';
   }
 
   const theme = useTheme2();
-  // imported GrafanaTheme2 from @grafana/data does not match type of same from @grafana/ui 
-  // @ts-ignore
   const styles = overhaulStyles(theme);
 
   type ValidDuration = {
@@ -328,22 +231,6 @@ export const PromSettings = (props: Props) => {
                   aria-label="Prometheus type"
                   options={prometheusFlavorSelectItems}
                   value={prometheusFlavorSelectItems.find((o) => o.value === options.jsonData.prometheusType)}
-                  // REMOVE AUTO DETECT UNTIL WE CAN COME UP WITH A NON CORE SOLUTION
-                  // onChange={onChangeHandler(
-                  //   'prometheusType',
-                  //   {
-                  //     ...options,
-                  //     jsonData: { ...options.jsonData, prometheusVersion: undefined },
-                  //   },
-                  //   (options) => {
-                  //     // Check buildinfo api and set default version if we can
-                  //     setPrometheusVersion(options, onOptionsChange, onUpdate);
-                  //     return onOptionsChange({
-                  //       ...options,
-                  //       jsonData: { ...options.jsonData, prometheusVersion: undefined },
-                  //     });
-                  //   }
-                  // )}
                   onChange={onChangeHandler('prometheusType', options, onOptionsChange)}
                   width={40}
                 />