better timeGroup macro handling for sub-second intervals

gabor · gabor · commit 8798476c7e3d · 2024-05-21T12:15:44.000+02:00
diff --git a/pkg/bigquery/macros.go b/pkg/bigquery/macros.go
@@ -46,7 +46,7 @@ func macroTimeGroup(query *sqlds.Query, args []string) (string, error) {
 
 	}
 
-	return fmt.Sprintf("TIMESTAMP_SECONDS(DIV(UNIX_SECONDS(%s), %v) * %v)", timeVar, interval.Seconds(), interval.Seconds()), nil
+	return fmt.Sprintf("TIMESTAMP_MILLIS(DIV(UNIX_MILLIS(%s), %v) * %v)", timeVar, interval.Milliseconds(), interval.Milliseconds()), nil
 }
 
 var macros = map[string]sqlds.MacroFunc{

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ func macroTimeGroup(query *sqlds.Query, args []string) (string, error) {`
`46`	`46`
`47`	`47`	`}`
`48`	`48`
`49`		`- return fmt.Sprintf("TIMESTAMP_SECONDS(DIV(UNIX_SECONDS(%s), %v) * %v)", timeVar, interval.Seconds(), interval.Seconds()), nil`
	`49`	`+ return fmt.Sprintf("TIMESTAMP_MILLIS(DIV(UNIX_MILLIS(%s), %v) * %v)", timeVar, interval.Milliseconds(), interval.Milliseconds()), nil`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`var macros = map[string]sqlds.MacroFunc{`