`grafana.plugin.install(...)` raises `niquests.exceptions.JSONDecodeError`

[amotl]

Problem

While it worked before, installing a plugin suddenly starts raising an error. We observed it happening on a PR submitted by Dependabot, GH-158.

niquests.exceptions.JSONDecodeError: response content is not JSON: line 1 column 1 (char 0)

-- https://github.com/grafana-toolbox/grafana-wtf/actions/runs/12567839419/job/35457426563?pr=158

Q&A

Any idea what could be going on here, @bhks?

[etiennevincent]

I think this is related to the change in this MR, but more generally to the logic defined here: https://github.com/grafana-toolbox/grafana-client/blob/main/grafana_client/client.py#L188
accept_empty_json is always False (except here ) meaning it will always re-raise the error

[amotl]

Hi. Thanks for your reply.

I will use this patch to restore CI, because apparently it still works on Grafana >= 10.

• Tests: test_plugins_status_app started tripping on Grafana < 10 #162

If you see a chance to fix the problem inside the code itself, please feel free to submit a patch, if you have the capacity, or otherwise advise for any changes you could see that should be made to the library.

[amotl]

Closing it for the time being. Thanks for your analysis.

[bhks]

If I remember it was tested on Grafana 9.

Seems like we are good now.