feat(update): Supplementary update 11fd584c3943369cfe467e20b2df58f44f27034a

Author: gouzil

README.md

@@ -6,7 +6,7 @@
 
 ## 这是一个什么项目？
 
-这是一个把github desktop翻译成中文的项目, 当前翻译版本[here](https://github.com/gouzil/github-desktop-zh/tree/releases/3.0.1-test7)
+这是一个把github desktop翻译成中文的项目, 当前翻译版本[release-3.0.2](https://github.com/gouzil/github-desktop-zh/tree/release-3.0.2)
 
 ## 部分截图
 

app/package.json

@@ -3,7 +3,7 @@
   "productName": "GitHub Desktop",
   "bundleID": "com.github.GitHubClient",
   "companyName": "GitHub, Inc.",
-  "version": "3.0.1-beta1",
+  "version": "3.0.2",
   "main": "./main.js",
   "repository": {
     "type": "git",
@@ -26,7 +26,7 @@
     "codemirror-mode-elixir": "^1.1.2",
     "compare-versions": "^3.6.0",
     "deep-equal": "^1.0.1",
-    "desktop-notifications": "^0.2.0",
+    "desktop-notifications": "^0.2.2",
     "desktop-trampoline": "desktop/desktop-trampoline#v0.9.8",
     "dexie": "^2.0.0",
     "dompurify": "^2.3.3",

app/src/main-process/app-window.ts

@@ -21,7 +21,10 @@ import * as path from 'path'
 import windowStateKeeper from 'electron-window-state'
 import * as ipcMain from './ipc-main'
 import * as ipcWebContents from './ipc-webcontents'
-import { installNotificationCallback } from './notifications'
+import {
+  installNotificationCallback,
+  terminateDesktopNotifications,
+} from './notifications'
 
 export class AppWindow {
   private window: Electron.BrowserWindow
@@ -107,6 +110,7 @@ export class AppWindow {
       }
       nativeTheme.removeAllListeners()
       autoUpdater.removeAllListeners()
+      terminateDesktopNotifications()
     })
 
     if (__WIN32__) {

app/src/main-process/notifications.ts

@@ -1,6 +1,7 @@
 import {
   initializeNotifications,
   onNotificationEvent,
+  terminateNotifications,
 } from 'desktop-notifications'
 import { BrowserWindow } from 'electron'
 import { findToastActivatorClsid } from '../lib/find-toast-activator-clsid'
@@ -35,6 +36,10 @@ export function initializeDesktopNotifications() {
   initializeNotifications({ toastActivatorClsid: windowsToastActivatorClsid })
 }
 
+export function terminateDesktopNotifications() {
+  terminateNotifications()
+}
+
 export function installNotificationCallback(window: BrowserWindow) {
   onNotificationEvent<DesktopAliveEvent>((event, id, userInfo) => {
     ipcWebContents.send(

app/yarn.lock

@@ -363,10 +363,10 @@ delegates@^1.0.0:
   resolved "https://registry.yarnpkg.com/delegates/-/delegates-1.0.0.tgz#84c6e159b81904fdca59a0ef44cd870d31250f9a"
   integrity sha1-hMbhWbgZBP3KWaDvRM2HDTElD5o=
 
-desktop-notifications@^0.2.0:
-  version "0.2.0"
-  resolved "https://registry.yarnpkg.com/desktop-notifications/-/desktop-notifications-0.2.0.tgz#8ec6d732671d42e9aa4dac4523a2a57806c9e210"
-  integrity sha512-6puOHRkSHmH1HpQDftFtpJU+ko7gw1vtSlf2LViJX+sY2N+9pVuYO85HjTlpktHDSVKvDnFGhPVAoZmjXIvo/Q==
+desktop-notifications@^0.2.2:
+  version "0.2.2"
+  resolved "https://registry.yarnpkg.com/desktop-notifications/-/desktop-notifications-0.2.2.tgz#197a32ee504a894ad074793dab285681c533e5ac"
+  integrity sha512-XMnxdWV6ZfiCzLZNC00n6h30Jt3z8yv21FAPBt/kK6hANI0PaoYWsRKEYya0zMUAX/9lrh429R5OtRGOKWZQSw==
   dependencies:
     node-addon-api "^5.0.0"
     prebuild-install "^7.0.1"

changelog.json

@@ -1,5 +1,9 @@
 {
   "releases": {
+    "3.0.2": [
+      "[Fixed] Fix crash launching the app on macOS High Sierra - #14712",
+      "[Fixed] Terminate all GitHub Desktop processes on Windows when the app is closed - #14733. Thanks @tsvetilian-ty!"
+    ],
     "3.0.1-beta1": [
       "[Added] Add support for PyCharm Community Edition on Windows - #14411. Thanks @tsvetilian-ty!",
       "[Added] Add support for highlighting .mjs/.cjs/.mts/.cts files as JavaScript/TypeScript - #14481. Thanks @j-f1!",