Skip to content

Commit 9d94f3a

Browse files
PierrickVouletpierrick
andauthored
feat: fix style for builders (#1093)
Co-authored-by: pierrick <pierrick@google.com>
1 parent 22656cb commit 9d94f3a

23 files changed

+149
-222
lines changed

chat/client-libraries/cloud/src/main/java/com/google/workspace/api/chat/samples/CreateMembershipUserCred.java

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -36,22 +36,16 @@ public static void main(String[] args) throws Exception {
3636
try (ChatServiceClient chatServiceClient =
3737
AuthenticationUtils.createClientWithUserCredentials(
3838
ImmutableList.of(SCOPE))) {
39-
CreateMembershipRequest request =
40-
CreateMembershipRequest.newBuilder()
41-
// replace SPACE_NAME here
42-
.setParent("spaces/SPACE_NAME")
43-
.setMembership(
44-
Membership.newBuilder()
45-
.setMember(
46-
User.newBuilder()
47-
// replace USER_NAME here
48-
.setName("users/USER_NAME")
49-
// user type for the membership
50-
.setType(User.Type.HUMAN)
51-
.build())
52-
.build())
53-
.build();
54-
Membership response = chatServiceClient.createMembership(request);
39+
CreateMembershipRequest.Builder request = CreateMembershipRequest.newBuilder()
40+
// replace SPACE_NAME here
41+
.setParent("spaces/SPACE_NAME")
42+
.setMembership(Membership.newBuilder()
43+
.setMember(User.newBuilder()
44+
// replace USER_NAME here
45+
.setName("users/USER_NAME")
46+
// user type for the membership
47+
.setType(User.Type.HUMAN)));
48+
Membership response = chatServiceClient.createMembership(request.build());
5549

5650
System.out.println(JsonFormat.printer().print(response));
5751
}

chat/client-libraries/cloud/src/main/java/com/google/workspace/api/chat/samples/CreateMembershipUserCredForApp.java

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -36,22 +36,16 @@ public static void main(String[] args) throws Exception {
3636
try (ChatServiceClient chatServiceClient =
3737
AuthenticationUtils.createClientWithUserCredentials(
3838
ImmutableList.of(SCOPE))) {
39-
CreateMembershipRequest request =
40-
CreateMembershipRequest.newBuilder()
41-
// replace SPACE_NAME here
42-
.setParent("spaces/SPACE_NAME")
43-
.setMembership(
44-
Membership.newBuilder()
45-
.setMember(
46-
User.newBuilder()
47-
// member name for app membership, do not change this.
48-
.setName("users/app")
49-
// user type for the membership
50-
.setType(User.Type.BOT)
51-
.build())
52-
.build())
53-
.build();
54-
Membership response = chatServiceClient.createMembership(request);
39+
CreateMembershipRequest.Builder request = CreateMembershipRequest.newBuilder()
40+
// replace SPACE_NAME here
41+
.setParent("spaces/SPACE_NAME")
42+
.setMembership(Membership.newBuilder()
43+
.setMember(User.newBuilder()
44+
// member name for app membership, do not change this.
45+
.setName("users/app")
46+
// user type for the membership
47+
.setType(User.Type.BOT)));
48+
Membership response = chatServiceClient.createMembership(request.build());
5549

5650
System.out.println(JsonFormat.printer().print(response));
5751
}

chat/client-libraries/cloud/src/main/java/com/google/workspace/api/chat/samples/CreateMessageAppCredAtMention.java

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,15 @@ public class CreateMessageAppCredAtMention {
2929
public static void main(String[] args) throws Exception {
3030
try (ChatServiceClient chatServiceClient =
3131
AuthenticationUtils.createClientWithAppCredentials()) {
32-
CreateMessageRequest request =
33-
CreateMessageRequest.newBuilder()
32+
CreateMessageRequest.Builder request = CreateMessageRequest.newBuilder()
3433
// Replace SPACE_NAME here.
3534
.setParent("spaces/SPACE_NAME")
36-
.setMessage(
37-
Message.newBuilder()
38-
// The user with USER_NAME will be mentioned if they are in the
39-
// space.
40-
// Replace USER_NAME here
41-
.setText("Hello <users/USER_NAME>!")
42-
.build())
43-
.build();
44-
Message response = chatServiceClient.createMessage(request);
35+
.setMessage(Message.newBuilder()
36+
// The user with USER_NAME will be mentioned if they are in the
37+
// space.
38+
// Replace USER_NAME here
39+
.setText("Hello <users/USER_NAME>!"));
40+
Message response = chatServiceClient.createMessage(request.build());
4541

4642
System.out.println(JsonFormat.printer().print(response));
4743
}

chat/client-libraries/cloud/src/main/java/com/google/workspace/api/chat/samples/CreateMessageUserCredWithMessageId.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,20 +34,16 @@ public static void main(String[] args) throws Exception {
3434
try (ChatServiceClient chatServiceClient =
3535
AuthenticationUtils.createClientWithUserCredentials(
3636
ImmutableList.of(SCOPE))) {
37-
CreateMessageRequest request =
38-
CreateMessageRequest.newBuilder()
37+
CreateMessageRequest.Builder request = CreateMessageRequest.newBuilder()
3938
// Replace SPACE_NAME here.
4039
.setParent("spaces/SPACE_NAME")
41-
.setMessage(
42-
Message.newBuilder()
43-
.setText("Hello with user credentials!")
44-
.build())
40+
.setMessage(Message.newBuilder()
41+
.setText("Hello with user credentials!"))
4542
// Message ID lets chat apps get, update or delete a message without
4643
// needing to store the system assigned ID in the message's resource
4744
// name.
48-
.setMessageId("client-MESSAGE-ID")
49-
.build();
50-
Message response = chatServiceClient.createMessage(request);
45+
.setMessageId("client-MESSAGE-ID");
46+
Message response = chatServiceClient.createMessage(request.build());
5147

5248
System.out.println(JsonFormat.printer().print(response));
5349
}

chat/client-libraries/cloud/src/main/java/com/google/workspace/api/chat/samples/CreateMessageUserCredWithRequestId.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,19 +34,15 @@ public static void main(String[] args) throws Exception {
3434
try (ChatServiceClient chatServiceClient =
3535
AuthenticationUtils.createClientWithUserCredentials(
3636
ImmutableList.of(SCOPE))) {
37-
CreateMessageRequest request =
38-
CreateMessageRequest.newBuilder()
37+
CreateMessageRequest.Builder request = CreateMessageRequest.newBuilder()
3938
// Replace SPACE_NAME here.
4039
.setParent("spaces/SPACE_NAME")
41-
.setMessage(
42-
Message.newBuilder()
43-
.setText("Hello with user credentials!")
44-
.build())
40+
.setMessage(Message.newBuilder()
41+
.setText("Hello with user credentials!"))
4542
// Specifying an existing request ID returns the message created with
4643
// that ID instead of creating a new message.
47-
.setRequestId("REQUEST_ID")
48-
.build();
49-
Message response = chatServiceClient.createMessage(request);
44+
.setRequestId("REQUEST_ID");
45+
Message response = chatServiceClient.createMessage(request.build());
5046

5147
System.out.println(JsonFormat.printer().print(response));
5248
}

chat/client-libraries/cloud/src/main/java/com/google/workspace/api/chat/samples/CreateMessageUserCredWithThreadKey.java

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,23 +36,19 @@ public static void main(String[] args) throws Exception {
3636
try (ChatServiceClient chatServiceClient =
3737
AuthenticationUtils.createClientWithUserCredentials(
3838
ImmutableList.of(SCOPE))) {
39-
CreateMessageRequest request =
40-
CreateMessageRequest.newBuilder()
39+
CreateMessageRequest.Builder request = CreateMessageRequest.newBuilder()
4140
// Replace SPACE_NAME here.
4241
.setParent("spaces/SPACE_NAME")
4342
// Creates the message as a reply to the thread specified by thread_key.
4443
// If it fails, the message starts a new thread instead.
4544
.setMessageReplyOption(
46-
MessageReplyOption.REPLY_MESSAGE_FALLBACK_TO_NEW_THREAD)
47-
.setMessage(
48-
Message.newBuilder()
49-
.setText("Hello with user credentials!")
50-
// Thread key specifies a thread and is unique to the chat app
51-
// that sets it.
52-
.setThread(Thread.newBuilder().setThreadKey("THREAD_KEY").build())
53-
.build())
54-
.build();
55-
Message response = chatServiceClient.createMessage(request);
45+
MessageReplyOption.REPLY_MESSAGE_FALLBACK_TO_NEW_THREAD)
46+
.setMessage(Message.newBuilder()
47+
.setText("Hello with user credentials!")
48+
// Thread key specifies a thread and is unique to the chat app
49+
// that sets it.
50+
.setThread(Thread.newBuilder().setThreadKey("THREAD_KEY")));
51+
Message response = chatServiceClient.createMessage(request.build());
5652

5753
System.out.println(JsonFormat.printer().print(response));
5854
}

chat/client-libraries/cloud/src/main/java/com/google/workspace/api/chat/samples/CreateMessageUserCredWithThreadName.java

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,24 +36,20 @@ public static void main(String[] args) throws Exception {
3636
try (ChatServiceClient chatServiceClient =
3737
AuthenticationUtils.createClientWithUserCredentials(
3838
ImmutableList.of(SCOPE))) {
39-
CreateMessageRequest request =
40-
CreateMessageRequest.newBuilder()
39+
CreateMessageRequest.Builder request = CreateMessageRequest.newBuilder()
4140
// Replace SPACE_NAME here.
4241
.setParent("spaces/SPACE_NAME")
4342
// Creates the message as a reply to the thread specified by thread name.
4443
// If it fails, the message starts a new thread instead.
4544
.setMessageReplyOption(
46-
MessageReplyOption.REPLY_MESSAGE_FALLBACK_TO_NEW_THREAD)
47-
.setMessage(
48-
Message.newBuilder()
49-
.setText("Hello with user credentials!")
50-
// Resource name of a thread that uniquely identify a thread.
51-
.setThread(Thread.newBuilder().setName(
52-
// replace SPACE_NAME and THREAD_NAME here
53-
"spaces/SPACE_NAME/threads/THREAD_NAME").build())
54-
.build())
55-
.build();
56-
Message response = chatServiceClient.createMessage(request);
45+
MessageReplyOption.REPLY_MESSAGE_FALLBACK_TO_NEW_THREAD)
46+
.setMessage(Message.newBuilder()
47+
.setText("Hello with user credentials!")
48+
// Resource name of a thread that uniquely identify a thread.
49+
.setThread(Thread.newBuilder().setName(
50+
// replace SPACE_NAME and THREAD_NAME here
51+
"spaces/SPACE_NAME/threads/THREAD_NAME")));
52+
Message response = chatServiceClient.createMessage(request.build());
5753

5854
System.out.println(JsonFormat.printer().print(response));
5955
}

chat/client-libraries/cloud/src/main/java/com/google/workspace/api/chat/samples/DeleteMessageAppCred.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,10 @@ public class DeleteMessageAppCred {
2626
public static void main(String[] args) throws Exception {
2727
try (ChatServiceClient chatServiceClient =
2828
AuthenticationUtils.createClientWithAppCredentials()) {
29-
DeleteMessageRequest request =
30-
DeleteMessageRequest.newBuilder()
31-
// replace SPACE_NAME and MESSAGE_NAME here
32-
.setName("spaces/SPACE_NAME/messages/MESSAGE_NAME")
33-
.build();
34-
chatServiceClient.deleteMessage(request);
29+
DeleteMessageRequest.Builder request = DeleteMessageRequest.newBuilder()
30+
// replace SPACE_NAME and MESSAGE_NAME here
31+
.setName("spaces/SPACE_NAME/messages/MESSAGE_NAME");
32+
chatServiceClient.deleteMessage(request.build());
3533
}
3634
}
3735
}

chat/client-libraries/cloud/src/main/java/com/google/workspace/api/chat/samples/DeleteMessageUserCred.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,10 @@ public static void main(String[] args) throws Exception {
3232
try (ChatServiceClient chatServiceClient =
3333
AuthenticationUtils.createClientWithUserCredentials(
3434
ImmutableList.of(SCOPE))) {
35-
DeleteMessageRequest request =
36-
DeleteMessageRequest.newBuilder()
37-
// replace SPACE_NAME and MESSAGE_NAME here
38-
.setName("spaces/SPACE_NAME/messages/MESSAGE_NAME")
39-
.build();
40-
chatServiceClient.deleteMessage(request);
35+
DeleteMessageRequest.Builder request = DeleteMessageRequest.newBuilder()
36+
// replace SPACE_NAME and MESSAGE_NAME here
37+
.setName("spaces/SPACE_NAME/messages/MESSAGE_NAME");
38+
chatServiceClient.deleteMessage(request.build());
4139
}
4240
}
4341
}

chat/client-libraries/cloud/src/main/java/com/google/workspace/api/chat/samples/GetMembershipAppCred.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,10 @@ public class GetMembershipAppCred {
2828
public static void main(String[] args) throws Exception {
2929
try (ChatServiceClient chatServiceClient =
3030
AuthenticationUtils.createClientWithAppCredentials()) {
31-
GetMembershipRequest request =
32-
GetMembershipRequest.newBuilder()
33-
// replace SPACE_NAME and MEMBERSHIP_NAME here
34-
.setName("spaces/SPACE_NAME/members/MEMBERSHIP_NAME")
35-
.build();
36-
Membership response = chatServiceClient.getMembership(request);
31+
GetMembershipRequest.Builder request = GetMembershipRequest.newBuilder()
32+
// replace SPACE_NAME and MEMBERSHIP_NAME here
33+
.setName("spaces/SPACE_NAME/members/MEMBERSHIP_NAME");
34+
Membership response = chatServiceClient.getMembership(request.build());
3735

3836
System.out.println(JsonFormat.printer().print(response));
3937
}

0 commit comments

Comments
 (0)