-
Notifications
You must be signed in to change notification settings - Fork 89
feat: add support for asynchronous rest streaming #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 15 commits
4df2120
26f52a5
204920a
2014ef6
fdeb437
8014f47
e84f03a
91f5c13
0c2ee5c
75ae7d7
db7cfb3
9da0113
87eeca3
d6abddd
a6a648d
8d30b2d
0b51b09
7d8f1e1
d793069
5f48f72
70d1cdb
ee3a5ac
5a6e488
f2180da
bc811e5
fc74ae0
1603818
cee06ab
380dedf
750d4cb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,109 @@ | ||
# Copyright 2024 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Helpers for server-side streaming in REST.""" | ||
|
||
from collections import deque | ||
import string | ||
from typing import Deque, Union | ||
|
||
import proto | ||
import google.protobuf.message | ||
from google.protobuf.json_format import Parse | ||
|
||
|
||
class BaseResponseIterator: | ||
"""Base Iterator over REST API responses. This class should not be used directly. | ||
|
||
Args: | ||
response (requests.Response): An API response object. | ||
response_message_cls (Union[proto.Message, google.protobuf.message.Message]): A response | ||
class expected to be returned from an API. | ||
|
||
Raises: | ||
ValueError: If `response_message_cls` is not a subclass of `proto.Message` or `google.protobuf.message.Message`. | ||
""" | ||
|
||
def __init__( | ||
self, | ||
response_message_cls: Union[proto.Message, google.protobuf.message.Message], | ||
): | ||
self._response_message_cls = response_message_cls | ||
# Inner iterator over HTTP response's content. | ||
# self._response_itr = self._response.iter_content(decode_unicode=True) | ||
vchudnov-g marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# Contains a list of JSON responses ready to be sent to user. | ||
self._ready_objs: Deque[str] = deque() | ||
# Current JSON response being built. | ||
self._obj = "" | ||
# Keeps track of the nesting level within a JSON object. | ||
self._level = 0 | ||
# Keeps track whether HTTP response is currently sending values | ||
# inside of a string value. | ||
self._in_string = False | ||
# Whether an escape symbol "\" was encountered. | ||
self._escape_next = False | ||
|
||
def _process_chunk(self, chunk: str): | ||
if self._level == 0: | ||
if chunk[0] != "[": | ||
raise ValueError( | ||
"Can only parse array of JSON objects, instead got %s" % chunk | ||
) | ||
for char in chunk: | ||
if char == "{": | ||
if self._level == 1: | ||
# Level 1 corresponds to the outermost JSON object | ||
# (i.e. the one we care about). | ||
self._obj = "" | ||
if not self._in_string: | ||
self._level += 1 | ||
self._obj += char | ||
elif char == "}": | ||
self._obj += char | ||
if not self._in_string: | ||
self._level -= 1 | ||
if not self._in_string and self._level == 1: | ||
self._ready_objs.append(self._obj) | ||
elif char == '"': | ||
# Helps to deal with an escaped quotes inside of a string. | ||
if not self._escape_next: | ||
self._in_string = not self._in_string | ||
self._obj += char | ||
elif char in string.whitespace: | ||
if self._in_string: | ||
self._obj += char | ||
elif char == "[": | ||
if self._level == 0: | ||
self._level += 1 | ||
else: | ||
self._obj += char | ||
elif char == "]": | ||
if self._level == 1: | ||
self._level -= 1 | ||
else: | ||
self._obj += char | ||
else: | ||
self._obj += char | ||
self._escape_next = not self._escape_next if char == "\\" else False | ||
|
||
def _grab(self): | ||
# Add extra quotes to make json.loads happy. | ||
if issubclass(self._response_message_cls, proto.Message): | ||
return self._response_message_cls.from_json(self._ready_objs.popleft()) | ||
vchudnov-g marked this conversation as resolved.
Show resolved
Hide resolved
|
||
elif issubclass(self._response_message_cls, google.protobuf.message.Message): | ||
return Parse(self._ready_objs.popleft(), self._response_message_cls()) | ||
else: | ||
raise ValueError( | ||
"Response message class must be a subclass of proto.Message or google.protobuf.message.Message." | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
# Copyright 2024 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Helpers for server-side asynchronous streaming in REST.""" | ||
|
||
from typing import Union | ||
|
||
import proto | ||
import google.auth.aio.transport | ||
import google.protobuf.message | ||
from google.api_core._rest_streaming_base import BaseResponseIterator | ||
|
||
|
||
class AsyncResponseIterator(BaseResponseIterator): | ||
"""Asynchronous Iterator over REST API responses. | ||
|
||
Args: | ||
response (google.auth.aio.transport.Response): An API response object. | ||
response_message_cls (Union[proto.Message, google.protobuf.message.Message]): A response | ||
class expected to be returned from an API. | ||
|
||
Raises: | ||
ValueError: | ||
- If `response_message_cls` is not a subclass of `proto.Message` or `google.protobuf.message.Message`. | ||
- If `response` is not an instance of `google.auth.aio.transport.aiohttp.Response`. | ||
vchudnov-g marked this conversation as resolved.
Show resolved
Hide resolved
|
||
""" | ||
|
||
def __init__( | ||
self, | ||
response: google.auth.aio.transport.Response, | ||
response_message_cls: Union[proto.Message, google.protobuf.message.Message], | ||
): | ||
self._response = response | ||
self._chunk_size = 1024 | ||
self._response_itr = self._response.content().__aiter__() | ||
super(AsyncResponseIterator, self).__init__( | ||
response_message_cls=response_message_cls | ||
) | ||
|
||
async def cancel(self): | ||
"""Cancel existing streaming operation.""" | ||
await self._response.close() | ||
|
||
async def __anext__(self): | ||
while not self._ready_objs: | ||
try: | ||
chunk = await self._response_itr.__anext__() | ||
chunk = chunk.decode("utf-8") | ||
self._process_chunk(chunk) | ||
except StopAsyncIteration as e: | ||
if self._level > 0: | ||
raise ValueError("i Unfinished stream: %s" % self._obj) | ||
raise e | ||
except ValueError as e: | ||
raise e | ||
return self._grab() | ||
|
||
def __aiter__(self): | ||
return self | ||
|
||
async def __aexit__(self, exc_type, exc, tb): | ||
"""Cancel existing async streaming operation.""" | ||
await self._response.close() |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,70 @@ | ||||||
# Copyright 2024 Google LLC | ||||||
# | ||||||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
# you may not use this file except in compliance with the License. | ||||||
# You may obtain a copy of the License at | ||||||
# | ||||||
# http://www.apache.org/licenses/LICENSE-2.0 | ||||||
# | ||||||
# Unless required by applicable law or agreed to in writing, software | ||||||
# distributed under the License is distributed on an "AS IS" BASIS, | ||||||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
# See the License for the specific language governing permissions and | ||||||
# limitations under the License. | ||||||
|
||||||
|
||||||
vchudnov-g marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
import logging | ||||||
from typing import List | ||||||
|
||||||
import proto | ||||||
|
||||||
from google.protobuf import duration_pb2 | ||||||
from google.protobuf import timestamp_pb2 | ||||||
from google.protobuf.json_format import MessageToJson | ||||||
|
||||||
|
||||||
class Genre(proto.Enum): | ||||||
GENRE_UNSPECIFIED = 0 | ||||||
CLASSICAL = 1 | ||||||
JAZZ = 2 | ||||||
ROCK = 3 | ||||||
|
||||||
|
||||||
class Composer(proto.Message): | ||||||
given_name = proto.Field(proto.STRING, number=1) | ||||||
family_name = proto.Field(proto.STRING, number=2) | ||||||
relateds = proto.RepeatedField(proto.STRING, number=3) | ||||||
indices = proto.MapField(proto.STRING, proto.STRING, number=4) | ||||||
|
||||||
|
||||||
class Song(proto.Message): | ||||||
composer = proto.Field(Composer, number=1) | ||||||
title = proto.Field(proto.STRING, number=2) | ||||||
lyrics = proto.Field(proto.STRING, number=3) | ||||||
year = proto.Field(proto.INT32, number=4) | ||||||
genre = proto.Field(Genre, number=5) | ||||||
is_five_mins_longer = proto.Field(proto.BOOL, number=6) | ||||||
score = proto.Field(proto.DOUBLE, number=7) | ||||||
likes = proto.Field(proto.INT64, number=8) | ||||||
duration = proto.Field(duration_pb2.Duration, number=9) | ||||||
date_added = proto.Field(timestamp_pb2.Timestamp, number=10) | ||||||
|
||||||
|
||||||
class EchoResponse(proto.Message): | ||||||
content = proto.Field(proto.STRING, number=1) | ||||||
|
||||||
|
||||||
def parse_responses(response_message_cls, responses: List[proto.Message]) -> bytes: | ||||||
# json.dumps returns a string surrounded with quotes that need to be stripped | ||||||
# in order to be an actual JSON. | ||||||
json_responses = [ | ||||||
( | ||||||
response_message_cls.to_json(r).strip('"') | ||||||
if issubclass(response_message_cls, proto.Message) | ||||||
else MessageToJson(r).strip('"') | ||||||
) | ||||||
for r in responses | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
One letter character names make plain text searching hard. And things are easier if variable names are not substrings of each other. Hence this suggestion. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. addressed. |
||||||
] | ||||||
logging.info(f"Sending JSON stream: {json_responses}") | ||||||
ret_val = "[{}]".format(",".join(json_responses)) | ||||||
return bytes(ret_val, "utf-8") |
Uh oh!
There was an error while loading. Please reload this page.