Skip to content

Commit 35cc00a

Browse files
committed
added comment to clarify timeouts
1 parent 1bbd1f0 commit 35cc00a

File tree

4 files changed

+12
-0
lines changed

4 files changed

+12
-0
lines changed

google/api_core/retry/retry_streaming.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,8 @@ def on_error(e):
280280
maximum (float): The maximum amount of time to delay in seconds.
281281
multiplier (float): The multiplier applied to the delay.
282282
timeout (float): How long to keep retrying, in seconds.
283+
Note: timeout is only checked before initiating a retry, so the target may
284+
run past the timeout value as long as it is healthy.
283285
on_error (Callable[Exception]): A function to call while processing
284286
a retryable exception. Any error raised by this function will
285287
*not* be caught.

google/api_core/retry/retry_streaming_async.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,8 @@ def on_error(e):
265265
maximum (float): The maximum amount of time to delay in seconds.
266266
multiplier (float): The multiplier applied to the delay.
267267
timeout (Optional[float]): How long to keep retrying in seconds.
268+
Note: timeout is only checked before initiating a retry, so the target may
269+
run past the timeout value as long as it is healthy.
268270
on_error (Optional[Callable[Exception]]): A function to call while processing
269271
a retryable exception. Any error raised by this function will
270272
*not* be caught.

google/api_core/retry/retry_unary.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,8 @@ def retry_target(
108108
sleep_generator (Iterable[float]): An infinite iterator that determines
109109
how long to sleep between retries.
110110
timeout (Optional[float]): How long to keep retrying the target.
111+
Note: timeout is only checked before initiating a retry, so the target may
112+
run past the timeout value as long as it is healthy.
111113
on_error (Optional[Callable[Exception]]): If given, the on_error
112114
callback will be called with each retryable exception raised by the
113115
target. Any error raised by this function will *not* be caught.
@@ -250,6 +252,8 @@ class Retry(_BaseRetry):
250252
maximum (float): The maximum amount of time to delay in seconds.
251253
multiplier (float): The multiplier applied to the delay.
252254
timeout (float): How long to keep retrying, in seconds.
255+
Note: timeout is only checked before initiating a retry, so the target may
256+
run past the timeout value as long as it is healthy.
253257
on_error (Callable[Exception]): A function to call while processing
254258
a retryable exception. Any error raised by this function will
255259
*not* be caught.

google/api_core/retry/retry_unary_async.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,8 @@ async def retry_target(
118118
sleep_generator (Iterable[float]): An infinite iterator that determines
119119
how long to sleep between retries.
120120
timeout (Optional[float]): How long to keep retrying the target, in seconds.
121+
Note: timeout is only checked before initiating a retry, so the target may
122+
run past the timeout value as long as it is healthy.
121123
on_error (Optional[Callable[Exception]]): If given, the on_error
122124
callback will be called with each retryable exception raised by the
123125
target. Any error raised by this function will *not* be caught.
@@ -187,6 +189,8 @@ class AsyncRetry(_BaseRetry):
187189
maximum (float): The maximum amount of time to delay in seconds.
188190
multiplier (float): The multiplier applied to the delay.
189191
timeout (Optional[float]): How long to keep retrying in seconds.
192+
Note: timeout is only checked before initiating a retry, so the target may
193+
run past the timeout value as long as it is healthy.
190194
on_error (Optional[Callable[Exception]]): A function to call while processing
191195
a retryable exception. Any error raised by this function will
192196
*not* be caught.

0 commit comments

Comments
 (0)