Skip to content

Commit 108f9d4

Browse files
authored
Fix branch coverage for un-called callbacks. (#6242)
Use 'mock.Mock()' w/ 'return_value' True, rather than inlining 'lambda _: True' in cases where the callback doesn't get called.
1 parent 151a0c1 commit 108f9d4

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

tests/unit/test_bidi.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,9 @@ def cancel(self):
280280

281281
class TestResumableBidiRpc(object):
282282
def test_initial_state(self):
283-
bidi_rpc = bidi.ResumableBidiRpc(None, lambda _: True)
283+
callback = mock.Mock()
284+
callback.return_value = True
285+
bidi_rpc = bidi.ResumableBidiRpc(None, callback)
284286

285287
assert bidi_rpc.is_active is False
286288

@@ -380,7 +382,9 @@ def test_recv_recover_already_recovered(self):
380382
grpc.StreamStreamMultiCallable,
381383
instance=True,
382384
side_effect=[call_1, call_2])
383-
bidi_rpc = bidi.ResumableBidiRpc(start_rpc, lambda _: True)
385+
callback = mock.Mock()
386+
callback.return_value = True
387+
bidi_rpc = bidi.ResumableBidiRpc(start_rpc, callback)
384388

385389
bidi_rpc.open()
386390

0 commit comments

Comments
 (0)