Skip to content

Commit 0423ebe

Browse files
committed
fixed mypy issues
1 parent 265d998 commit 0423ebe

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

google/api_core/retry_streaming.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def __init__(
5858
be caught.
5959
"""
6060
self.target_fn = target
61-
self.active_target: Iterator = self.target_fn().__iter__()
61+
self.active_target: Iterator[T] = self.target_fn().__iter__()
6262
self.predicate = predicate
6363
self.sleep_generator = iter(sleep_generator)
6464
self.on_error = on_error
@@ -106,7 +106,7 @@ def _handle_exception(self, exc) -> None:
106106
"Retrying due to {}, sleeping {:.1f}s ...".format(exc, next_sleep)
107107
)
108108
time.sleep(next_sleep)
109-
self.active_target = self.target_fn()
109+
self.active_target = self.target_fn().__iter__()
110110

111111
def __next__(self) -> T:
112112
"""
@@ -130,7 +130,8 @@ def close(self) -> None:
130130
- AttributeError if the active_target does not have a close() method
131131
"""
132132
if getattr(self.active_target, "close", None):
133-
return self.active_target.close()
133+
casted_target = cast(Generator, self.active_target)
134+
return casted_target.close()
134135
else:
135136
raise AttributeError(
136137
"close() not implemented for {}".format(self.active_target)

google/api_core/retry_streaming_async.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,11 @@
2323
AsyncIterable,
2424
Awaitable,
2525
Union,
26-
Any,
2726
TypeVar,
2827
AsyncGenerator,
2928
)
3029

3130
import asyncio
32-
import inspect
3331
import logging
3432
import datetime
3533

@@ -118,7 +116,7 @@ async def _handle_exception(self, exc) -> None:
118116
except StopIteration:
119117
raise ValueError("Sleep generator stopped yielding sleep values")
120118
# if time budget is exceeded, raise RetryError
121-
if self.remaining_timeout_budget is not None:
119+
if self.remaining_timeout_budget is not None and self.timeout is not None:
122120
if self.remaining_timeout_budget <= next_sleep:
123121
raise exceptions.RetryError(
124122
"Timeout of {:.1f}s exceeded".format(self.timeout),

0 commit comments

Comments
 (0)