From 2d792c1a3f9cd23ad75e782d558fa1f2ff1c32f1 Mon Sep 17 00:00:00 2001 From: Anubhav Dhawan Date: Thu, 3 Apr 2025 19:43:12 +0530 Subject: [PATCH 1/2] fix: Add qualname for ToolboxTool instances --- packages/toolbox-core/src/toolbox_core/tool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/toolbox-core/src/toolbox_core/tool.py b/packages/toolbox-core/src/toolbox_core/tool.py index c83051ca..0c8cd831 100644 --- a/packages/toolbox-core/src/toolbox_core/tool.py +++ b/packages/toolbox-core/src/toolbox_core/tool.py @@ -86,7 +86,7 @@ def __init__( self.__doc__ = desc self.__signature__ = Signature(parameters=params, return_annotation=str) self.__annotations__ = {p.name: p.annotation for p in params} - # TODO: self.__qualname__ ?? + self.__qualname__ = f"{self.__class__.__qualname__}.{name}" # map of parameter name to auth service required by it self.__required_authn_params = required_authn_params From 710ad6aea2f90c6dd47a0c29d97948c8739922fc Mon Sep 17 00:00:00 2001 From: Anubhav Dhawan Date: Thu, 3 Apr 2025 23:24:33 +0530 Subject: [PATCH 2/2] Use self.__name__ instead of directly using the name --- packages/toolbox-core/src/toolbox_core/tool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/toolbox-core/src/toolbox_core/tool.py b/packages/toolbox-core/src/toolbox_core/tool.py index 8b8b2524..4e5fdac7 100644 --- a/packages/toolbox-core/src/toolbox_core/tool.py +++ b/packages/toolbox-core/src/toolbox_core/tool.py @@ -87,7 +87,7 @@ def __init__( parameters=inspect_type_params, return_annotation=str ) self.__annotations__ = {p.name: p.annotation for p in inspect_type_params} - self.__qualname__ = f"{self.__class__.__qualname__}.{name}" + self.__qualname__ = f"{self.__class__.__qualname__}.{self.__name__}" # map of parameter name to auth service required by it self.__required_authn_params = required_authn_params