deps: make dropwizard metrics an optional dependency (#4224)

Change-Id: I708bc5dcb432f3516787d23cb7d769c8a1c678ab

Author: igorbernstein2

bigtable-hbase-1.x-parent/bigtable-hbase-1.x-hadoop/pom.xml

@@ -91,18 +91,6 @@ limitations under the License.
       <version>${reload4j.version}</version>
       <scope>runtime</scope>
     </dependency>
-    <dependency>
-      <groupId>io.dropwizard.metrics</groupId>
-      <artifactId>metrics-core</artifactId>
-      <version>${hbase1-metrics.version}</version>
-      <exclusions>
-        <!-- see slf4j notes below -->
-        <exclusion>
-          <groupId>org.slf4j</groupId>
-          <artifactId>slf4j-api</artifactId>
-        </exclusion>
-      </exclusions>
-    </dependency>
 
     <!-- unlike hbase-shaded-client, hbase-client depends on slf4j 1.6.1.
       Which is older than the version requested by metrics-core. However,

bigtable-hbase-1.x-parent/bigtable-hbase-1.x-shaded/pom.xml

@@ -191,11 +191,7 @@ limitations under the License.
       <artifactId>commons-logging</artifactId>
       <version>${commons-logging.version}</version>
     </dependency>
-    <dependency>
-      <groupId>io.dropwizard.metrics</groupId>
-      <artifactId>metrics-core</artifactId>
-      <version>${hbase1-metrics.version}</version>
-    </dependency>
+
     <!--needs to be declared as a dependency to be excluded from shading-->
     <dependency>
       <groupId>com.google.code.findbugs</groupId>
@@ -220,7 +216,7 @@ limitations under the License.
             <configuration>
               <excludedScopes>test,provided,system</excludedScopes>
               <!-- Should mirror the shade plugin exclusions-->
-              <excludedArtifacts>metrics-core|commons-logging|hbase-shaded-client|slf4j-api|slf4j-log4j12|log4j|htrace-core|findbugs-annotations|htrace-core4|jsr305</excludedArtifacts>
+              <excludedArtifacts>commons-logging|hbase-shaded-client|slf4j-api|slf4j-log4j12|log4j|htrace-core|findbugs-annotations|htrace-core4|jsr305</excludedArtifacts>
               <excludedGroups>javax.annotation|org.checkerframework</excludedGroups>
               <generateBundle>true</generateBundle>
             </configuration>
@@ -268,7 +264,6 @@ limitations under the License.
               <artifactSet>
                 <excludes>
                   <!-- exclude user visible deps -->
-                  <exclude>io.dropwizard.metrics:metrics-core</exclude>
                   <exclude>commons-logging:commons-logging</exclude>
                   <exclude>ch.qos.reload4j:reload4j</exclude>
                   <!-- exclude hbase-shaded-client & all of its dependencies -->

bigtable-hbase-1.x-parent/bigtable-hbase-1.x/pom.xml

@@ -100,11 +100,6 @@ limitations under the License.
       <groupId>com.google.guava</groupId>
       <artifactId>guava</artifactId>
     </dependency>
-    <dependency>
-      <groupId>io.dropwizard.metrics</groupId>
-      <artifactId>metrics-core</artifactId>
-      <version>${hbase1-metrics.version}</version>
-    </dependency>
 
     <!-- deps for metrics instrumentation, these should be removed once we expose more hooks in veneer metrics -->
     <dependency>
@@ -178,6 +173,12 @@ limitations under the License.
       <version>2.12.1-SNAPSHOT</version> <!-- {x-version-update:bigtable-client-parent:current} -->
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>io.dropwizard.metrics</groupId>
+      <artifactId>metrics-graphite</artifactId>
+      <version>${dropwizard-metrics.version}</version>
+      <scope>test</scope>
+    </dependency>
     <dependency>
       <groupId>com.google.truth</groupId>
       <artifactId>truth</artifactId>
@@ -193,7 +194,7 @@ limitations under the License.
     <dependency>
       <groupId>io.dropwizard.metrics</groupId>
       <artifactId>metrics-graphite</artifactId>
-      <version>${hbase1-metrics.version}</version>
+      <version>${dropwizard-metrics.version}</version>
       <scope>test</scope>
     </dependency>
     <dependency>

bigtable-hbase-2.x-parent/bigtable-hbase-2.x-hadoop/pom.xml

@@ -84,18 +84,6 @@ limitations under the License.
       <artifactId>commons-logging</artifactId>
       <version>${commons-logging.version}</version>
     </dependency>
-    <dependency>
-      <groupId>io.dropwizard.metrics</groupId>
-      <artifactId>metrics-core</artifactId>
-      <version>${hbase2-metrics.version}</version>
-      <exclusions>
-        <!-- see slf4j notes below -->
-        <exclusion>
-          <groupId>org.slf4j</groupId>
-          <artifactId>slf4j-api</artifactId>
-        </exclusion>
-      </exclusions>
-    </dependency>
 
     <!-- unlike hbase-shaded-client, hbase-client depends on slf4j 1.6.1.
       Which is older than the version requested by metrics-core. However,

bigtable-hbase-2.x-parent/bigtable-hbase-2.x-shaded/pom.xml

@@ -174,11 +174,6 @@ limitations under the License.
       <artifactId>commons-logging</artifactId>
       <version>${commons-logging.version}</version>
     </dependency>
-    <dependency>
-      <groupId>io.dropwizard.metrics</groupId>
-      <artifactId>metrics-core</artifactId>
-      <version>${hbase2-metrics.version}</version>
-    </dependency>
 
     <!--    needs to be declared as a dependency to be excluded from shading-->
     <dependency>
@@ -204,7 +199,7 @@ limitations under the License.
             <configuration>
               <excludedScopes>test,provided,system</excludedScopes>
               <!--Should match the exclusions of shade plugin-->
-              <excludedArtifacts>metrics-core|commons-logging|hbase-shaded-client|slf4j-api|slf4j-log4j12|log4j|htrace-core4|audience-annotations|findbugs-annotations|jsr305</excludedArtifacts>
+              <excludedArtifacts>commons-logging|hbase-shaded-client|slf4j-api|slf4j-log4j12|log4j|htrace-core4|audience-annotations|findbugs-annotations|jsr305</excludedArtifacts>
               <excludedGroups>javax.annotation|org.checkerframework</excludedGroups>
               <generateBundle>true</generateBundle>
             </configuration>
@@ -252,7 +247,6 @@ limitations under the License.
               <artifactSet>
                 <excludes>
                   <!-- exclude user visible deps -->
-                  <exclude>io.dropwizard.metrics:metrics-core</exclude>
                   <exclude>commons-logging:commons-logging</exclude>
                   <!-- exclude hbase-shaded-client & all of its dependencies -->
                   <exclude>org.apache.hbase:hbase-shaded-client</exclude>

bigtable-hbase-2.x-parent/bigtable-hbase-2.x/pom.xml

@@ -147,11 +147,6 @@ limitations under the License.
       <groupId>io.opencensus</groupId>
       <artifactId>opencensus-api</artifactId>
     </dependency>
-    <dependency>
-      <groupId>io.dropwizard.metrics</groupId>
-      <artifactId>metrics-core</artifactId>
-      <version>${hbase2-metrics.version}</version>
-    </dependency>
     <dependency>
       <groupId>org.threeten</groupId>
       <artifactId>threetenbp</artifactId>
@@ -170,7 +165,7 @@ limitations under the License.
     <dependency>
       <groupId>io.dropwizard.metrics</groupId>
       <artifactId>metrics-graphite</artifactId>
-      <version>${hbase2-metrics.version}</version>
+      <version>${dropwizard-metrics.version}</version>
       <scope>test</scope>
     </dependency>
 

hbase-migration-tools/mirroring-client/bigtable-hbase-mirroring-client-2.x-parent/bigtable-hbase-mirroring-client-1.x-2.x-integration-tests/pom.xml

@@ -334,14 +334,6 @@ limitations under the License.
       <version>1.7.30</version>
       <scope>test</scope>
     </dependency>
-
-    <!-- Pinned to prevent Enforcer errors -->
-    <dependency>
-      <groupId>io.dropwizard.metrics</groupId>
-      <artifactId>metrics-core</artifactId>
-      <version>3.2.6</version>
-      <scope>test</scope>
-    </dependency>
   </dependencies>
 
   <build>

hbase-migration-tools/mirroring-client/bigtable-hbase-mirroring-client-2.x-parent/bigtable-hbase-mirroring-client-2.x-integration-tests/pom.xml

@@ -345,14 +345,6 @@ limitations under the License.
       <version>1.7.30</version>
       <scope>test</scope>
     </dependency>
-
-    <!-- Pinned to prevent Enforcer errors -->
-    <dependency>
-      <groupId>io.dropwizard.metrics</groupId>
-      <artifactId>metrics-core</artifactId>
-      <version>3.2.6</version>
-      <scope>test</scope>
-    </dependency>
   </dependencies>
 
   <build>

pom.xml

@@ -59,6 +59,8 @@ limitations under the License.
     <bigtable.version>2.28.0</bigtable.version>
     <google-cloud-bigtable-emulator.version>0.165.0</google-cloud-bigtable-emulator.version>
     <bigtable-metrics-api.version>1.29.2</bigtable-metrics-api.version>
+    <!-- Optional dep for bigtable-metrics-api used for tests -->
+    <dropwizard-metrics.version>4.2.21</dropwizard-metrics.version>
 
     <!--  keeping at this version to align with hbase-->
     <slf4j.version>1.7.25</slf4j.version>
@@ -68,9 +70,7 @@ limitations under the License.
 
     <!-- hbase dependency versions -->
     <hbase1.version>1.7.2</hbase1.version>
-    <hbase1-metrics.version>3.1.2</hbase1-metrics.version>
     <hbase2.version>2.3.6</hbase2.version>
-    <hbase2-metrics.version>3.2.6</hbase2-metrics.version>
 
     <!-- bytebuddy dependency version for resolving hbase backward incompatible changes -->
     <byte.buddy.version>1.14.2</byte.buddy.version>