Skip to content

Commit 5b27310

Browse files
chore: remove unnecessary dep on guava in tools (#4221)
Change-Id: I52be2d2af5b10c37c3cdc791a45f14b17499f57f Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable-hbase/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
1 parent ee15b1c commit 5b27310

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

bigtable-hbase-1.x-parent/bigtable-hbase-1.x-tools/pom.xml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,6 @@
8484
<version>1.2.11</version>
8585
<scope>runtime</scope>
8686
</dependency>
87-
<dependency>
88-
<groupId>com.google.guava</groupId>
89-
<artifactId>guava</artifactId>
90-
<version>${guava.version}</version>
91-
<!-- todo: align guava deps - we use repackaged guava in the main classes-->
92-
<scope>test</scope>
93-
</dependency>
9487
<dependency>
9588
<groupId>org.mockito</groupId>
9689
<artifactId>mockito-core</artifactId>

bigtable-hbase-1.x-parent/bigtable-hbase-1.x-tools/src/test/java/com/google/cloud/bigtable/hbase/tools/HBaseSchemaTransformerTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import com.google.bigtable.repackaged.com.google.gson.JsonObject;
2323
import com.google.cloud.bigtable.hbase.tools.ClusterSchemaDefinition.TableSchemaDefinition;
2424
import com.google.cloud.bigtable.hbase.tools.HBaseSchemaTranslator.JsonBasedSchemaTransformer;
25-
import com.google.common.collect.ImmutableMap;
2625
import java.io.FileWriter;
2726
import java.io.IOException;
2827
import java.io.Writer;
@@ -88,8 +87,9 @@ public void testParseJsonTables() throws IOException {
8887
schemaTransformer = JsonBasedSchemaTransformer.newSchemaTransformerFromJsonFile(schemaFilePath);
8988

9089
// Validate
91-
Map<String, String> expectedTableMapping =
92-
ImmutableMap.of("old-table", "new-table", "old-table-2", "random-table-2");
90+
Map<String, String> expectedTableMapping = new HashMap<>();
91+
expectedTableMapping.put("old-table", "new-table");
92+
expectedTableMapping.put("old-table-2", "random-table-2");
9393
assertEquals(expectedTableMapping, schemaTransformer.tableNameMappings);
9494
}
9595

0 commit comments

Comments
 (0)