Skip to content

Commit dfcc004

Browse files
graememorganchingor13
authored andcommitted
Make GenericUrl's #equals pass static analysis (#440)
We'll start matching this with a new error-prone (https://github.com/google/error-prone) check soon otherwise: it looks like this is comparing two different getters.
1 parent a71b8ac commit dfcc004

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ public boolean equals(Object obj) {
183183
}
184184
GenericUrl other = (GenericUrl) obj;
185185
// TODO(yanivi): optimize?
186-
return build().equals(other.toString());
186+
return build().equals(other.build());
187187
}
188188

189189
@Override

0 commit comments

Comments
 (0)