fix arraymap iterator remove issue (#371)

* fix arraymap iterator remove issue

* fix code style

Author: yantzu

google-http-client/src/main/java/com/google/api/client/util/ArrayMap.java

@@ -381,6 +381,7 @@ public Map.Entry<K, V> next() {
         throw new NoSuchElementException();
       }
       this.nextIndex++;
+      this.removed = false;
       return new Entry(index);
     }
 
@@ -390,6 +391,7 @@ public void remove() {
         throw new IllegalArgumentException();
       }
       ArrayMap.this.remove(index);
+      this.nextIndex--;
       this.removed = true;
     }
   }

google-http-client/src/test/java/com/google/api/client/util/ArrayMapTest.java

@@ -16,6 +16,9 @@
 
 import junit.framework.TestCase;
 
+import java.util.Iterator;
+import java.util.Map;
+
 /**
  * Tests {@link ArrayMap}.
  *
@@ -109,4 +112,52 @@ public void testHashCode() {
 
     assertTrue(map.hashCode() > 0);
   }
+
+  public void testIteratorRemove1() {
+    ArrayMap<String, String> map = new ArrayMap<String, String>();
+    map.put("a", "a");
+    map.put("b", "b");
+    map.put("c", "c");
+    Iterator<Map.Entry<String, String>> iter = map.entrySet().iterator();
+    while (iter.hasNext()) {
+      Map.Entry<String, String> entry = iter.next();
+      if (!"all".equalsIgnoreCase(entry.getKey())) {
+        iter.remove();
+      }
+    }
+    assertEquals(0, map.size());
+  }
+
+  public void testIteratorRemove2() {
+    ArrayMap<String, String> map = new ArrayMap<String, String>();
+    map.put("a", "a");
+    map.put("b", "b");
+    map.put("c", "c");
+    Iterator<Map.Entry<String, String>> iter = map.entrySet().iterator();
+    while (iter.hasNext()) {
+      Map.Entry<String, String> entry = iter.next();
+      if ("b".equalsIgnoreCase(entry.getKey())) {
+        iter.remove();
+      }
+    }
+    assertEquals(2, map.size());
+    assertEquals("a", map.get("a"));
+    assertEquals("c", map.get("c"));
+  }
+
+  public void testIteratorRemove3() {
+    ArrayMap<String, String> map = new ArrayMap<String, String>();
+    map.put("a", "a");
+    map.put("b", "b");
+    map.put("c", "c");
+    Iterator<Map.Entry<String, String>> iter = map.entrySet().iterator();
+    while (iter.hasNext()) {
+      Map.Entry<String, String> entry = iter.next();
+      if (!"b".equalsIgnoreCase(entry.getKey())) {
+        iter.remove();
+      }
+    }
+    assertEquals(1, map.size());
+    assertEquals("b", map.get("b"));
+  }
 }