Skip to content

Commit 44777a9

Browse files
authored
Update OpenCensus deprecations (#556)
1 parent 19f6756 commit 44777a9

File tree

2 files changed

+14
-16
lines changed

2 files changed

+14
-16
lines changed

google-http-client/src/main/java/com/google/api/client/util/OpenCensusUtils.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
import io.opencensus.contrib.http.util.HttpPropagationUtil;
2323
import io.opencensus.trace.BlankSpan;
2424
import io.opencensus.trace.EndSpanOptions;
25-
import io.opencensus.trace.NetworkEvent;
26-
import io.opencensus.trace.NetworkEvent.Type;
25+
import io.opencensus.trace.MessageEvent;
26+
import io.opencensus.trace.MessageEvent.Type;
2727
import io.opencensus.trace.Span;
2828
import io.opencensus.trace.Status;
2929
import io.opencensus.trace.Tracer;
@@ -40,7 +40,7 @@
4040
* Utilities for Census monitoring and tracing.
4141
*
4242
* @author Hailong Wen
43-
* @since 1.24
43+
* @since 1.28
4444
*/
4545
public class OpenCensusUtils {
4646

@@ -213,12 +213,12 @@ public static void recordSentMessageEvent(Span span, long size) {
213213
* @param size Size of the response.
214214
*/
215215
public static void recordReceivedMessageEvent(Span span, long size) {
216-
recordMessageEvent(span, size, Type.RECV);
216+
recordMessageEvent(span, size, Type.RECEIVED);
217217
}
218218

219219
/**
220-
* Records a message event of a certain {@link NetworkEvent.Type}. This method is package
221-
* protected since {@link NetworkEvent} might be deprecated in future releases.
220+
* Records a message event of a certain {@link MessageEvent.Type}. This method is package
221+
* protected since {@link MessageEvent} might be deprecated in future releases.
222222
*
223223
* @param span The {@code span} in which the event occurs.
224224
* @param size Size of the message.
@@ -230,11 +230,11 @@ static void recordMessageEvent(Span span, long size, Type eventType) {
230230
if (size < 0) {
231231
size = 0;
232232
}
233-
NetworkEvent event = NetworkEvent
233+
MessageEvent event = MessageEvent
234234
.builder(eventType, idGenerator.getAndIncrement())
235235
.setUncompressedMessageSize(size)
236236
.build();
237-
span.addNetworkEvent(event);
237+
span.addMessageEvent(event);
238238
}
239239

240240
static {

google-http-client/src/test/java/com/google/api/client/util/OpenCensusUtilsTest.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import io.opencensus.trace.Annotation;
2222
import io.opencensus.trace.AttributeValue;
2323
import io.opencensus.trace.Link;
24-
import io.opencensus.trace.NetworkEvent;
24+
import io.opencensus.trace.MessageEvent;
2525
import io.opencensus.trace.Span;
2626
import io.opencensus.trace.SpanContext;
2727
import io.opencensus.trace.Status;
@@ -30,8 +30,6 @@
3030
import java.util.List;
3131
import java.util.Map;
3232
import junit.framework.TestCase;
33-
import org.junit.Assert;
34-
import org.junit.Rule;
3533

3634
/**
3735
* Tests {@link OpenCensusUtils}.
@@ -87,8 +85,8 @@ public void addAnnotation(String description, Map<String, AttributeValue> attrib
8785
public void addAnnotation(Annotation annotation) {}
8886

8987
@Override
90-
public void addNetworkEvent(NetworkEvent event) {
91-
throw new UnsupportedOperationException("Span.addNetworkEvent");
88+
public void addMessageEvent(MessageEvent event) {
89+
throw new UnsupportedOperationException("Span.addMessageEvent");
9290
}
9391

9492
@Override
@@ -221,7 +219,7 @@ public void testGetEndSpanOptionsOther() {
221219

222220
public void testRecordMessageEventInNullSpan() {
223221
try {
224-
OpenCensusUtils.recordMessageEvent(null, 0, NetworkEvent.Type.SENT);
222+
OpenCensusUtils.recordMessageEvent(null, 0, MessageEvent.Type.SENT);
225223
fail("expected " + IllegalArgumentException.class);
226224
} catch (IllegalArgumentException e) {
227225
assertEquals(e.getMessage(), "span should not be null.");
@@ -230,10 +228,10 @@ public void testRecordMessageEventInNullSpan() {
230228

231229
public void testRecordMessageEvent() {
232230
try {
233-
OpenCensusUtils.recordMessageEvent(mockSpan, 0, NetworkEvent.Type.SENT);
231+
OpenCensusUtils.recordMessageEvent(mockSpan, 0, MessageEvent.Type.SENT);
234232
fail("expected " + UnsupportedOperationException.class);
235233
} catch (UnsupportedOperationException e) {
236-
assertEquals(e.getMessage(), "Span.addNetworkEvent");
234+
assertEquals(e.getMessage(), "Span.addMessageEvent");
237235
}
238236
}
239237
}

0 commit comments

Comments
 (0)