Skip to content

Commit 5af9ef9

Browse files
committed
Revert changes to idtoken
1 parent bd342ea commit 5af9ef9

File tree

4 files changed

+2
-29
lines changed

4 files changed

+2
-29
lines changed

google/auth/impersonated_credentials.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -602,7 +602,6 @@ def refresh(self, request):
602602
"Content-Type": "application/json",
603603
metrics.API_CLIENT_HEADER: metrics.token_request_id_token_impersonate(),
604604
}
605-
headers.update(self._target_credentials._get_trust_boundary_header())
606605

607606
authed_session = AuthorizedSession(
608607
self._target_credentials._source_credentials, auth_request=request

google/oauth2/_client.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,6 @@ def call_iam_generate_id_token_endpoint(
327327
signer_email,
328328
audience,
329329
access_token,
330-
headers=None,
331330
universe_domain=credentials.DEFAULT_UNIVERSE_DOMAIN,
332331
):
333332
"""Call iam.generateIdToken endpoint to get ID token.
@@ -340,7 +339,6 @@ def call_iam_generate_id_token_endpoint(
340339
generateIdToken endpoint.
341340
audience (str): The audience for the ID token.
342341
access_token (str): The access token used to call the IAM endpoint.
343-
headers (Optional[Mapping[str, str]]): The headers for the request.
344342
universe_domain (str): The universe domain for the request. The
345343
default is ``googleapis.com``.
346344
@@ -357,7 +355,6 @@ def call_iam_generate_id_token_endpoint(
357355
body,
358356
access_token=access_token,
359357
use_json=True,
360-
headers=headers,
361358
)
362359

363360
try:

google/oauth2/service_account.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -921,16 +921,13 @@ def _refresh_with_iam_endpoint(self, request):
921921
)
922922
jwt_credentials.refresh(request)
923923

924-
headers = self._get_trust_boundary_header()
925-
926924
self.token, self.expiry = _client.call_iam_generate_id_token_endpoint(
927925
request,
928926
self._iam_id_token_endpoint,
929927
self.signer_email,
930928
self._target_audience,
931929
jwt_credentials.token.decode(),
932-
headers=headers,
933-
universe_domain=self._universe_domain,
930+
self._universe_domain,
934931
)
935932

936933
@_helpers.copy_docstring(credentials.Credentials)

tests/oauth2/test__client.py

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -347,26 +347,6 @@ def test_call_iam_generate_id_token_endpoint():
347347
assert expiry == now
348348

349349

350-
def test_call_iam_generate_id_token_endpoint_with_headers():
351-
now = _helpers.utcnow()
352-
id_token_expiry = _helpers.datetime_to_secs(now)
353-
id_token = jwt.encode(SIGNER, {"exp": id_token_expiry}).decode("utf-8")
354-
request = make_request({"token": id_token})
355-
headers = {"x-test-header": "test-value"}
356-
357-
_client.call_iam_generate_id_token_endpoint(
358-
request,
359-
iam._IAM_IDTOKEN_ENDPOINT,
360-
"fake_email",
361-
"fake_audience",
362-
"fake_access_token",
363-
headers=headers,
364-
universe_domain="googleapis.com",
365-
)
366-
367-
assert request.call_args[1]["headers"]["x-test-header"] == "test-value"
368-
369-
370350
def test_call_iam_generate_id_token_endpoint_no_id_token():
371351
request = make_request(
372352
{
@@ -382,7 +362,7 @@ def test_call_iam_generate_id_token_endpoint_no_id_token():
382362
"fake_email",
383363
"fake_audience",
384364
"fake_access_token",
385-
universe_domain="googleapis.com",
365+
"googleapis.com",
386366
)
387367
assert excinfo.match("No ID token in response")
388368

0 commit comments

Comments
 (0)