Skip to content

Commit 6769cda

Browse files
authored
build: fix mypy (#2092)
1 parent f76fdaf commit 6769cda

File tree

7 files changed

+7
-22
lines changed

7 files changed

+7
-22
lines changed

gapic/templates/noxfile.py.j2

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,7 @@ def cover(session):
176176
def mypy(session):
177177
"""Run the type checker."""
178178
session.install(
179-
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2066):
180-
# Ignore release of mypy 1.11.0 which may have a regression
181-
'mypy!=1.11.0',
179+
'mypy',
182180
'types-requests',
183181
'types-protobuf'
184182
)

noxfile.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -431,10 +431,7 @@ def showcase_mypy(
431431
):
432432
"""Perform typecheck analysis on the generated Showcase library."""
433433

434-
# Install pytest and gapic-generator-python
435-
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2066):
436-
# Ignore release of mypy 1.11.0 which may have a regression
437-
session.install("mypy!=1.11.0", "types-pkg-resources", "types-protobuf", "types-requests", "types-dataclasses")
434+
session.install("mypy", "types-setuptools", "types-protobuf", "types-requests", "types-dataclasses")
438435

439436
with showcase_library(session, templates=templates, other_opts=other_opts) as lib:
440437
session.chdir(lib)

tests/integration/goldens/asset/noxfile.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,7 @@ def cover(session):
187187
def mypy(session):
188188
"""Run the type checker."""
189189
session.install(
190-
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2066):
191-
# Ignore release of mypy 1.11.0 which may have a regression
192-
'mypy!=1.11.0',
190+
'mypy',
193191
'types-requests',
194192
'types-protobuf'
195193
)

tests/integration/goldens/credentials/noxfile.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,7 @@ def cover(session):
187187
def mypy(session):
188188
"""Run the type checker."""
189189
session.install(
190-
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2066):
191-
# Ignore release of mypy 1.11.0 which may have a regression
192-
'mypy!=1.11.0',
190+
'mypy',
193191
'types-requests',
194192
'types-protobuf'
195193
)

tests/integration/goldens/eventarc/noxfile.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,7 @@ def cover(session):
187187
def mypy(session):
188188
"""Run the type checker."""
189189
session.install(
190-
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2066):
191-
# Ignore release of mypy 1.11.0 which may have a regression
192-
'mypy!=1.11.0',
190+
'mypy',
193191
'types-requests',
194192
'types-protobuf'
195193
)

tests/integration/goldens/logging/noxfile.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,7 @@ def cover(session):
187187
def mypy(session):
188188
"""Run the type checker."""
189189
session.install(
190-
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2066):
191-
# Ignore release of mypy 1.11.0 which may have a regression
192-
'mypy!=1.11.0',
190+
'mypy',
193191
'types-requests',
194192
'types-protobuf'
195193
)

tests/integration/goldens/redis/noxfile.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,7 @@ def cover(session):
187187
def mypy(session):
188188
"""Run the type checker."""
189189
session.install(
190-
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2066):
191-
# Ignore release of mypy 1.11.0 which may have a regression
192-
'mypy!=1.11.0',
190+
'mypy',
193191
'types-requests',
194192
'types-protobuf'
195193
)

0 commit comments

Comments
 (0)