File tree Expand file tree Collapse file tree 1 file changed +12
-0
lines changed Expand file tree Collapse file tree 1 file changed +12
-0
lines changed Original file line number Diff line number Diff line change @@ -19,6 +19,18 @@ us first through the issue tracker with your idea so that we can help out and
19
19
possibly guide you. Coordinating up front makes it much easier to avoid
20
20
frustration later on.
21
21
22
+ ## Writing a new implementation
23
+
24
+ Before you start writing a new implementation, look at some of the existing ones. If you copy the
25
+ code structure from them, you are more likely to have fewer bugs and an easier review cycle.
26
+
27
+ If you create new algorithms to encode or decode, then your reviewer will have to spend more time
28
+ trying to understand your code in a language they may not be familiar with, and the review cycle
29
+ will take longer.
30
+
31
+ The reason we say this is because once code is accepted into our repository, we have the responsibility
32
+ to maintain and look after it. You are not writing the code for you, but for the OLC project team.
33
+
22
34
## Code reviews
23
35
All submissions, including submissions by project members, require review. We
24
36
use Github pull requests for this purpose.
You can’t perform that action at this time.
0 commit comments