codeLength input validation

drinckes · web-flow · commit 55207e149d73 · 2017-08-04T09:23:47.000+02:00
diff --git a/dart/lib/src/open_location_code.dart b/dart/lib/src/open_location_code.dart
@@ -220,7 +220,7 @@ bool isFull(String code) {
 /// including any separator characters.
 String encode(num latitude, num longitude, {int codeLength: pairCodeLength}) {
   if (codeLength < 2 ||
-      (codeLength < separatorPosition && codeLength % 2 == 1)) {
+      (codeLength < pairCodeLength && codeLength % 2 == 1)) {
     throw new ArgumentError('Invalid Open Location Code length: $codeLength');
   }
   // Ensure that latitude and longitude are valid.

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,7 @@ bool isFull(String code) {`
`220`	`220`	`/// including any separator characters.`
`221`	`221`	`String encode(num latitude, num longitude, {int codeLength: pairCodeLength}) {`
`222`	`222`	`if (codeLength < 2 \|\|`
`223`		`- (codeLength < separatorPosition && codeLength % 2 == 1)) {`
	`223`	`+ (codeLength < pairCodeLength && codeLength % 2 == 1)) {`
`224`	`224`	`throw new ArgumentError('Invalid Open Location Code length: $codeLength');`
`225`	`225`	`}`
`226`	`226`	`// Ensure that latitude and longitude are valid.`