Do not emit a #[test] attribute in the google_test macro if any attribute ending in test is detected.

This should eliminate problems with compatibility with most existing test libraries. It follows the same logic as used in the rstest crate; see https://github.com/la10736/rstest#inject-test-attribute.

PiperOrigin-RevId: 524239595

Author: hovinenb

googletest/integration_tests/google_test_with_rstest.rs

@@ -62,4 +62,20 @@ mod tests {
     fn paramterised_test_should_work_with_rstest_second(#[case] value: u32) -> Result<()> {
         verify_that!(value, eq(value))
     }
+
+    mod submodule {
+        pub use rstest::rstest as test;
+    }
+
+    #[google_test]
+    #[submodule::test]
+    fn test_should_work_with_qualified_test_annotation() -> Result<()> {
+        verify_that!(1, eq(1))
+    }
+
+    #[google_test]
+    #[test]
+    fn test_should_work_with_second_test_annotation() -> Result<()> {
+        verify_that!(1, eq(1))
+    }
 }

googletest/integration_tests/integration_tests.rs

@@ -466,9 +466,18 @@ mod tests {
             output,
             contains_substring("tests::test_should_work_with_rstest_second").times(eq(1))
         );
-        verify_that!(
+        expect_that!(
             output,
             contains_substring("tests::test_should_work_with_qualified_rstest_second").times(eq(1))
+        );
+        expect_that!(
+            output,
+            contains_substring("tests::test_should_work_with_qualified_test_annotation")
+                .times(eq(1))
+        );
+        verify_that!(
+            output,
+            contains_substring("tests::test_should_work_with_second_test_annotation").times(eq(1))
         )
     }
 

googletest_macro/src/lib.rs

@@ -92,7 +92,8 @@ fn is_test_attribute(attr: &Attribute) -> bool {
     let Some(last_segment) = attr.path().segments.last() else {
         return false;
     };
-    first_segment.ident == "rstest"
-        && last_segment.ident == "rstest"
-        && attr.path().segments.len() <= 2
+    last_segment.ident == "test"
+        || (first_segment.ident == "rstest"
+            && last_segment.ident == "rstest"
+            && attr.path().segments.len() <= 2)
 }