Skip to content

Can't submit a code review #112

@iveqy

Description

@iveqy

Hi,
I'm having problem to submit a code review. I'm doing
$ git appraise
Loaded 2 open reviews:
[pending] 8b692d60c974
Center checkbox, add padding

Solves: Odoo #869
[accepted] a2d5c3619740
Add missing dependency

The module won't installed without it since a view has dependencies
on a view in base_geolocalize

$ git appraise submit a2d5
Refusing to submit a non-fast-forward review. First merge the target ref.

Adding some debug prints to git appraise it seems as git appraise tries to merge a2d5 to origin/master which is wrong since a2d5 is the review and not the actually branch commit that should be merged.

I'm a bit puzzled about this, because this not working should mean that git appraise doesn't work for anyone and that seems not to be the case, so it might be me doing something wrong, but what?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions