Skip to content

Commit 33d5dd9

Browse files
committed
Improved pull request & clang-format instructions.
Change-Id: Ia439bcc61bac5788792244d10e573b1fba54b347
1 parent 105dd52 commit 33d5dd9

File tree

4 files changed

+17
-3
lines changed

4 files changed

+17
-3
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
Thank you for submitting a PR!
22

3-
Please make sure you include the names of the affected language(s) in your PR title.
3+
Please delete this standard text once you've created your own description.
4+
5+
Make sure you include the names of the affected language(s) in your PR title.
46
This helps us get the correct maintainers to look at your issue.
57

68
If you make changes to any of the code generators, be sure to run
@@ -11,6 +13,8 @@ If your PR includes C++ code, please adhere to the Google C++ Style Guide,
1113
and don't forget we try to support older compilers (e.g. VS2010, GCC 4.6.3),
1214
so only some C++11 support is available.
1315

16+
For any C++ changes, please make sure to run `sh src/clang-format-git.sh`
17+
1418
Include other details as appropriate.
1519

1620
Thanks!

src/clang-format-all.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# Running it twice corrects some bugs in clang-format.
2+
for run in {1..2}
3+
do
4+
clang-format -i -style=file include/flatbuffers/* src/*.cpp tests/*.cpp samples/*.cpp grpc/src/compiler/schema_interface.h grpc/tests/*.cpp
5+
done
6+
git checkout include/flatbuffers/reflection_generated.h

src/clang-format-git.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# Running it twice corrects some bugs in clang-format.
2+
for run in {1..2}
3+
do
4+
git clang-format HEAD^ -- include/flatbuffers/* src/*.cpp tests/*.cpp samples/*.cpp grpc/src/compiler/schema_interface.h grpc/tests/*.cpp
5+
done
6+
git checkout include/flatbuffers/reflection_generated.h

src/clang-format.sh

Lines changed: 0 additions & 2 deletions
This file was deleted.

0 commit comments

Comments
 (0)