Generate unusable functions and trait impls on error

This CL replaces bindings generation error comments with
generated functions and trait impls that will cause a
descriptive compiler error at time-of-use.

PiperOrigin-RevId: 715464169
Change-Id: Ia04a23bae1949574ad2a88d8b7eef58daa7c0ec2

Author: cramertj

common/errors.rs

@@ -47,10 +47,10 @@ impl Errors {
     /// Consolidates any errors into a single error message.
     ////
     /// Returns `Ok` if no errors have been added.
-    pub fn consolidate(&self) -> Result<(), Error> {
+    pub fn consolidate(&self) -> Result<(), error_report::ErrorList> {
         let errors = self.list.take();
         if !errors.is_empty() {
-            return Err(Error::from(error_report::ErrorList::from(errors)));
+            return Err(error_report::ErrorList::from(errors));
         }
         Ok(())
     }
@@ -59,7 +59,10 @@ impl Errors {
     /// list into a single error message.
     ///
     /// Returns `res` unchanged if it is `Ok`.
-    pub fn consolidate_on_err<T>(&self, res: Result<T, Error>) -> Result<T, Error> {
+    pub fn consolidate_on_err<T>(
+        &self,
+        res: Result<T, Error>,
+    ) -> Result<T, error_report::ErrorList> {
         res.map_err(|error| {
             self.add(error);
             self.consolidate().unwrap_err()

common/errors_test.rs

@@ -4,13 +4,13 @@
 
 use error_report::{anyhow, ErrorReport, ErrorReporting};
 use errors::Errors;
-// NOTE: verify_that imported for macro use. This should not be required.
-use googletest::{expect_eq, fail, gtest, verify_eq, verify_that};
+use googletest::{expect_eq, fail, gtest, OrFail};
 
 #[gtest]
-fn test_errors_consolidate_on_empty_list_returns_ok() {
+fn test_errors_consolidate_on_empty_list_returns_ok() -> googletest::Result<()> {
     let errors = Errors::new();
-    expect_eq!(errors.consolidate(), Ok(()));
+    errors.consolidate().or_fail()?;
+    Ok(())
 }
 
 #[gtest]
@@ -23,7 +23,7 @@ fn test_errors_consolidate_on_nonempty_list_returns_reportable_error() -> google
     };
 
     let report = ErrorReport::new();
-    report.report(&error);
+    report.report(&error.into());
     expect_eq!(
         serde_json::from_str::<serde_json::Value>(&report.to_json_string()).unwrap(),
         serde_json::json!({

rs_bindings_from_cc/generate_bindings/db.rs

@@ -3,12 +3,12 @@
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 use crate::generate_function::{
-    generate_function, get_binding, is_record_clonable, overloaded_funcs, FunctionId, ImplKind,
+    generate_function, get_binding, is_record_clonable, overloaded_funcs, FunctionId,
+    GeneratedFunction, ImplKind,
 };
 use crate::generate_struct_and_union::collect_unqualified_member_functions;
 use crate::rs_snippet::RsTypeKind;
 use crate::rs_type_kind;
-use crate::ApiSnippets;
 use arc_anyhow::Result;
 use error_report::ErrorReporting;
 use ffi_types::SourceLocationDocComment;
@@ -67,7 +67,6 @@ memoized::query_group! {
         #[input]
         fn errors(&self) -> Rc<dyn ErrorReporting>;
 
-
         /// A collection of errors that should cause bindings generation to fail.
         ///
         /// These errors should be issued only in response to misusage of Crubit itself, such as
@@ -80,7 +79,7 @@ memoized::query_group! {
 
         fn rs_type_kind(&self, rs_type: RsType) -> Result<RsTypeKind>;
 
-        fn generate_function(&self, func: Rc<Func>, record_overwrite: Option<Rc<Record>>) -> Result<Option<(Rc<ApiSnippets>, Rc<FunctionId>)>>;
+        fn generate_function(&self, func: Rc<Func>, record_overwrite: Option<Rc<Record>>) -> Result<Option<GeneratedFunction>>;
 
         fn overloaded_funcs(&self) -> Rc<HashSet<Rc<FunctionId>>>;