fix(DatabaseSessionService): Align event filtering and ordering logic #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses inconsistencies in how DatabaseSessionService handles config.after_timestamp and config.num_recent_events parameters, aligning its behavior with InMemorySessionService and VertexAiSessionService. Key changes: - Made after_timestamp filtering inclusive - Corrected num_recent_events behavior to fetch the N most recent events - Refined timezone handling for after_timestamp - Updated the unit test test_get_session_with_config to includeSessionServiceType.DATABASE, allowing verification of these fixes. Fixes google#911
ystory
force-pushed
the
fix/database-session-timestamp-recency
branch
from
e4f6475 to
d01a8fd
Compare
DeanChensj
approved these changes
May 27, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
May 27, 2025
Copybara import of the project: -- d01a8fd by Leo Yongsul Kim <ystory84@gmail.com>: fix(DatabaseSessionService): Align event filtering and ordering logic This commit addresses inconsistencies in how DatabaseSessionService handles config.after_timestamp and config.num_recent_events parameters, aligning its behavior with InMemorySessionService and VertexAiSessionService. Key changes: - Made after_timestamp filtering inclusive - Corrected num_recent_events behavior to fetch the N most recent events - Refined timezone handling for after_timestamp - Updated the unit test test_get_session_with_config to includeSessionServiceType.DATABASE, allowing verification of these fixes. Fixes #911 COPYBARA_INTEGRATE_REVIEW=#915 from ystory:fix/database-session-timestamp-recency 5cc8cf5 PiperOrigin-RevId: 763874840
|
Thanks for the fix! The PR is merged in c024ac5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses inconsistencies in how DatabaseSessionService handles config.after_timestamp and config.num_recent_events parameters, aligning its behavior with InMemorySessionService and VertexAiSessionService.
Key changes:
Fixes #911
Testing Plan
test_get_session_with_configlocated intests/unittests/sessions/test_session_service.pywas updated to be parameterized withSessionServiceType.DATABASE. This ensures that the corrected logic inDatabaseSessionServiceis explicitly tested against the same criteria as other session services.pytest ./tests/unittests/sessions/test_session_service.py.test_get_session_with_config, including all scenarios forSessionServiceType.DATABASE, have passed successfully.