Skip to content

Commit ba1887f

Browse files
fix: resolve path parameter extraction for complex Google API endpoints
Fixes #1814 - Fix GoogleApiToOpenApiConverter to properly handle path parameters in complex endpoints like /v1/documents/{documentId}:batchUpdate - Trust Google Discovery Document 'location' field over URL parsing - Add comprehensive test suite for Google Docs batchUpdate functionality - Verify parameter location handling for complex endpoint patterns - Test schema validation for BatchUpdateDocumentRequest/Response
1 parent a021222 commit ba1887f

File tree

2 files changed

+613
-1
lines changed

2 files changed

+613
-1
lines changed

src/google/adk/tools/google_api_tool/googleapi_to_openapi_converter.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,9 +391,11 @@ def _convert_operation(
391391
if param_name in path_params:
392392
continue
393393

394+
location = param_data.get("location", "query")
395+
394396
param = {
395397
"name": param_name,
396-
"in": "query",
398+
"in": location,
397399
"description": param_data.get("description", ""),
398400
"required": param_data.get("required", False),
399401
"schema": self._convert_parameter_schema(param_data),

0 commit comments

Comments
 (0)