-
Notifications
You must be signed in to change notification settings - Fork 33
chore: ignore Python caches, venvs, test artifacts, build outputs, ed… #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…itor/OS junk; keep repo clean
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @Ruafieldphase, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing repository cleanliness by substantially expanding the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a good set of rules to the .gitignore file to exclude common Python-related files, virtual environments, build artifacts, and editor-specific files. This is a great step towards keeping the repository clean. My review includes a suggestion to add a few more common patterns to make the ignore list even more robust and comprehensive, covering more tools and scenarios.
| # Python bytecode and caches | ||
| __pycache__/ | ||
| *.py[cod] | ||
| *$py.class | ||
|
|
||
| # Test artifacts | ||
| .pytest_cache/ | ||
| .coverage | ||
| htmlcov/ | ||
|
|
||
| # Virtual environments | ||
| .venv/ | ||
| venv/ | ||
| env/ | ||
| ENV/ | ||
|
|
||
| # Package build | ||
| build/ | ||
| dist/ | ||
| .eggs/ | ||
| *.egg-info/ | ||
|
|
||
| # IDE/Editor | ||
| .vscode/ | ||
| .idea/ | ||
|
|
||
| # OS junk | ||
| .DS_Store | ||
| Thumbs.db | ||
|
|
||
| # Logs | ||
| *.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great set of additions to the .gitignore file. To make it more comprehensive and prevent other common generated files from being accidentally committed, consider adding patterns for other popular Python tools (like mypy, ruff, pytype, cython), Jupyter notebooks, C extensions, and common editor backup files. I've suggested a more complete set of rules that incorporates these.
# Python bytecode and caches
__pycache__/
*.py[cod]
*$py.class
# Python tool caches
.mypy_cache/
.ruff_cache/
.pytype/
# Jupyter Notebook
.ipynb_checkpoints/
# C extensions
*.so
cython_debug/
# Test artifacts
.pytest_cache/
.coverage
htmlcov/
# Virtual environments
.venv/
venv/
env/
ENV/
# Package build
build/
dist/
.eggs/
*.egg-info/
# IDE/Editor
.vscode/
.idea/
*.swp
*~
# OS junk
.DS_Store
Thumbs.db
# Logs
*.log
- Add mypy, ruff, pytype cache patterns - Add Jupyter notebook checkpoints (.ipynb_checkpoints/) - Add C extension and Cython debug patterns (*.so, cython_debug/) - Add additional editor patterns (*.swp, *~) Addresses feedback from Gemini Code Assist review on PR google-gemini#130
…itor/OS junk; keep repo clean
Fixes #<issue_number_goes_here>