-
Notifications
You must be signed in to change notification settings - Fork 9.2k
feat(hooks): Hook Telemetry Infrastructure #9082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Edilmo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a robust telemetry infrastructure for the newly introduced hook system. It aims to provide deep insights into hook executions by capturing detailed event data, logging structured information, and collecting performance metrics. This foundational work is essential for monitoring the health, performance, and behavior of hooks, enabling efficient debugging and system optimization within the CLI. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a comprehensive telemetry and observability infrastructure for the new hook system, which is a great addition for debugging and monitoring. The changes include new configuration schemas, telemetry events, metrics, and a well-designed set of types for hooks. The introduction of a hookTranslator to decouple the hook API from the GenAI SDK is a solid architectural choice. However, I've found a critical issue in the implementation of the hookTranslator concerning the handling of GenerateContentResponse, which could lead to runtime errors. This needs to be addressed to ensure the stability of the new hook system.
e32f14a to
6e4dbe2
Compare
TLDR
Adds complete telemetry support for hook execution with structured logging and metrics collection for observability and debugging.
Part of full hook system implementation here
Dive Deeper
This implements the observability requirement for Hooks. The HookCallEvent class captures all relevant hook execution data (event name, hook type, input/output, duration, success/failure). The logHookCall function provides structured logging, while recordHookCallMetrics tracks performance metrics. This telemetry is essential for debugging hook issues and monitoring system performance.
Reviewer Test Plan
Testing Matrix
Linked issues / bugs
Closes #9081