Skip to content

Conversation

@Edilmo
Copy link
Contributor

@Edilmo Edilmo commented Sep 22, 2025

TLDR

Adds complete telemetry support for hook execution with structured logging and metrics collection for observability and debugging.
Part of full hook system implementation here

Dive Deeper

This implements the observability requirement for Hooks. The HookCallEvent class captures all relevant hook execution data (event name, hook type, input/output, duration, success/failure). The logHookCall function provides structured logging, while recordHookCallMetrics tracks performance metrics. This telemetry is essential for debugging hook issues and monitoring system performance.

Reviewer Test Plan

  • Run telemetry tests to verify event structure
  • Test hook execution generates proper telemetry events
  • Verify metrics collection works for both successful and failed hook executions
  • Check telemetry includes all required fields (duration, success, error details)

Testing Matrix

🍏 🪟 🐧
npm run
npx
Docker
Podman - -
Seatbelt - -

Linked issues / bugs

Closes #9081

@Edilmo Edilmo requested a review from a team as a code owner September 22, 2025 12:31
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Edilmo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes a robust telemetry infrastructure for the newly introduced hook system. It aims to provide deep insights into hook executions by capturing detailed event data, logging structured information, and collecting performance metrics. This foundational work is essential for monitoring the health, performance, and behavior of hooks, enabling efficient debugging and system optimization within the CLI.

Highlights

  • Hook Telemetry Infrastructure: Introduced comprehensive telemetry support for hook execution, including structured logging and metrics collection for enhanced observability and debugging.
  • New Hook Types and Configuration: Defined new enums (HookEventName, HookType) and interfaces (HookConfig, HookDefinition) for configuring hooks, and integrated these into the CLI's configuration and settings schema.
  • LLM Request/Response Translation: Added a HookTranslator class, specifically HookTranslatorGenAIv1, to facilitate seamless conversion between GenAI SDK types and stable Hook API types for LLM requests, responses, and tool configurations.
  • Detailed Hook Call Events: Implemented a HookCallEvent class to capture all relevant hook execution data, such as event name, hook type, input/output, duration, success/failure, and error details.
  • Metrics and Logging Integration: Integrated logHookCall for structured logging of hook events and recordHookCallMetrics for tracking performance metrics like call count and latency, enhancing the existing telemetry system.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive telemetry and observability infrastructure for the new hook system, which is a great addition for debugging and monitoring. The changes include new configuration schemas, telemetry events, metrics, and a well-designed set of types for hooks. The introduction of a hookTranslator to decouple the hook API from the GenAI SDK is a solid architectural choice. However, I've found a critical issue in the implementation of the hookTranslator concerning the handling of GenerateContentResponse, which could lead to runtime errors. This needs to be addressed to ensure the stability of the new hook system.

@Edilmo Edilmo force-pushed the edilmo/9081 branch 3 times, most recently from e32f14a to 6e4dbe2 Compare November 10, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hook Telemetry Infrastructure

3 participants