feat(core): Wire up chat code path for model configs. #12850
+424
−333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshualitt
changed the title
joshualitt
force-pushed
the
jl/overrides-3c
branch
from
c1c6a17 to
7854679
Compare
|
Size Change: -47 B (0%) Total Size: 20.5 MB ℹ️ View Unchanged
|
joshualitt
force-pushed
the
jl/overrides-3c
branch
4 times, most recently
from
1a02375 to
da7a3ee
Compare
joshualitt
force-pushed
the
jl/overrides-3c
branch
from
da7a3ee to
e5b13d2
Compare
joshualitt
changed the title
joshualitt
force-pushed
the
jl/overrides-3c
branch
from
e5b13d2 to
ef13a6c
Compare
joshualitt
commented
Nov 12, 2025
| tools: tools.length > 0 ? [{ functionDeclarations: tools }] : undefined, | ||
| const modelConfig = this.definition.modelConfig; | ||
|
|
||
| const runtimeAliasName = `${this.definition.name}-config`; |
Collaborator
Author
There was a problem hiding this comment.
Happy to just use the name for the model config alias, or some other suffix / prefix. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part 4 of 4 breaking up #12266. There are still some remaining tasks to attend to, but they will be handled as cleanup.
Details
Wires up the bulk of the remaining code paths for model configs. There is still one final use of a config internally, which I will address in a follow-up.
Related Issues
Related to #12589
How to Validate
Confirm configs look as expected.
Note: please see the current resolved model config aliases here.
Pre-Merge Checklist