Skip to content

Conversation

@georgehulme
Copy link

Summary

The authorization URL displayed during OAuth login was truncating on narrow terminals that don't break long tokens.

Details

This fix uses the existing wrap-ansi dependency to properly wrap the URL to the current terminal width, ensuring the full authorization link is displayed.

Both the NO_BROWSER user-code flow and the web login flow now display wrapped URLs that fit within the terminal width while maintaining readability.

Related Issues

Issue: #12137

How to Validate

Pre-Merge Checklist

  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

Problem: The authorization URL displayed during OAuth login was
truncating on narrow terminals that don't break long tokens.

Solution: This fix uses the existing wrap-ansi dependency to
properly wrap the URL to the current terminal width, ensuring the full
authorization link is displayed.

Both the NO_BROWSER user-code flow and the web login flow now display
wrapped URLs that fit within the terminal width while maintaining
readability.

Issue: google-gemini#12137
@georgehulme georgehulme requested a review from a team as a code owner November 10, 2025 00:43
@google-cla
Copy link

google-cla bot commented Nov 10, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @georgehulme, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a display bug where lengthy OAuth authorization URLs were not properly formatted in terminal output, leading to truncation. By integrating text wrapping functionality using an existing library, the change ensures that these critical URLs are always fully visible and readable, adapting to various terminal widths and enhancing the user's authentication experience.

Highlights

  • OAuth URL Truncation Fix: The pull request resolves an issue where OAuth authorization URLs were truncated in narrow terminals, making them difficult to read or copy.
  • Text Wrapping Implementation: The existing wrap-ansi dependency is now utilized to properly wrap long URLs to the current terminal width, ensuring full visibility.
  • Affected Flows: Both the NO_BROWSER user-code flow and the standard web login flow now display wrapped URLs, improving user experience across different authentication methods.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue where long OAuth login URLs could be truncated in narrow terminals. The solution uses the wrap-ansi package to wrap the URL to the terminal width, which has been correctly applied to both the web login and user-code authentication flows. My review includes one suggestion to improve code consistency and maintainability by refactoring the duplicated logic for determining terminal width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant