internal/gosym: preallocate inlined call slice

qmuntal · gopherbot · commit 63adf478672d · 2024-04-23T17:49:07.000Z
LineTable.InlineTree allocates a slice whose length is known in advance. Preallocate it to avoid reallocations. Change-Id: I1939f6d4e956ccb5d2b68e10695622784d8ced38 Reviewed-on: https://go-review.googlesource.com/c/vuln/+/581135 Run-TryBot: Quim Muntal <quimmuntal@gmail.com> Reviewed-by: Joedian Reid <joedian@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Quim Muntal <quimmuntal@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
diff --git a/internal/gosym/additions.go b/internal/gosym/additions.go
@@ -60,7 +60,7 @@ func (t *LineTable) InlineTree(f *Func, goFuncValue, baseAddr uint64, progReader
 	}
 
 	r := io.NewSectionReader(progReader, offset, 1<<32) // pick a size larger than we need
-	var ics []InlinedCall
+	ics := make([]InlinedCall, 0, f.inlineTreeCount)
 	for i := 0; i < f.inlineTreeCount; i++ {
 		if t.version >= ver120 {
 			var ric rawInlinedCall120

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ func (t LineTable) InlineTree(f Func, goFuncValue, baseAddr uint64, progReader`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`r := io.NewSectionReader(progReader, offset, 1<<32) // pick a size larger than we need`
`63`		`- var ics []InlinedCall`
	`63`	`+ ics := make([]InlinedCall, 0, f.inlineTreeCount)`
`64`	`64`	`for i := 0; i < f.inlineTreeCount; i++ {`
`65`	`65`	`if t.version >= ver120 {`
`66`	`66`	`var ric rawInlinedCall120`