incorrect exit code from dlv-dap

[katsusan]

I'm not sure this is a bug or I missed something, so first make a discussion here before issuing it.

source:

package main

import (
	"log"
	"os"
)

func main() {
	log.Println("should end here")
	os.Exit(222)
}

launch.json:

{
    "version": "0.3.0",
    "configurations": [
        {
            "name": "Launch",
            "type": "go",
            "request": "launch",
            "mode": "debug",
            "host": "127.0.0.1",
            "program": "${workspaceFolder}",
            "env": {"GOROOT":"D:\\Dev\\Go\\"},
            "args": [],
            "showLog": true
        }
    ]
}

output in debug console:

Starting: D:\Katsu\go\bin\dlv-dap.exe dap --listen=127.0.0.1:2066 --log=true
DAP server listening at: 127.0.0.1:2066
2021-08-23T18:09:23+08:00 info layer=debugger launching process with args: [D:\Projects\leetcode\__debug_bin.exe]
2021-08-23T18:09:23+08:00 debug layer=debugger continuing
2021/08/23 18:09:23 should end here
2021-08-23T18:09:23+08:00 debug layer=debugger halting
Process 1232 has exited with status 0   ← 1232 is the pid of __debug_bin.exe, so “exited with status 0” seems confusing
Detaching

use dlv-dap directly:

D:\Projects\leetcode>dlv-dap version
Delve Debugger
Version: 1.7.0
Build: $Id: 03c66357c10892f8b93d05c77ad27c1f4dd0cb2b $

D:\Projects\leetcode>dlv-dap debug 0warn.go 
Type 'help' for list of commands.
(dlv) c
2021/08/23 18:12:38 should end here
Process 13384 has exited with status 222

[polinasok]

I am unable to reproduce this on a Mac:

2021-08-24T10:03:21-07:00 debug layer=debugger continuing
2021/08/24 10:03:21 should end here
2021-08-24T10:03:21-07:00 debug layer=debugger halting
Process 72119 has exited with status 222
Detaching
2021-08-24T10:03:21-07:00 debug layer=debugger detaching
dlv dap (72104) exited with code: 0

We should add a server_test unittest for the status code that would run on all systems.

[suzmue]

Submitted issue #1717