Skip to content

Commit 0e61285

Browse files
authored
Update README.md and add CONTRIBUTING.md (#171)
Add files from C++ that are not in the Go list yet. Copy the C++ CONTRIBUTING.md file replacing C++ with Go.
1 parent cc00c76 commit 0e61285

File tree

2 files changed

+81
-7
lines changed

2 files changed

+81
-7
lines changed

CONTRIBUTING.md

Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,62 @@
1+
# How to contribute #
2+
3+
We'd love to accept your patches and contributions to this project. There are
4+
a just a few small guidelines you need to follow.
5+
6+
7+
## Contributor License Agreement ##
8+
9+
Contributions to any Google project must be accompanied by a Contributor
10+
License Agreement. This is not a copyright **assignment**, it simply gives
11+
Google permission to use and redistribute your contributions as part of the
12+
project.
13+
14+
* If you are an individual writing original source code and you're sure you
15+
own the intellectual property, then you'll need to sign an [individual
16+
CLA][].
17+
18+
* If you work for a company that wants to allow you to contribute your work,
19+
then you'll need to sign a [corporate CLA][].
20+
21+
You generally only need to submit a CLA once, so if you've already submitted
22+
one (even if it was for a different project), you probably don't need to do it
23+
again.
24+
25+
[individual CLA]: https://developers.google.com/open-source/cla/individual
26+
[corporate CLA]: https://developers.google.com/open-source/cla/corporate
27+
28+
29+
## Submitting a patch ##
30+
31+
1. It's generally best to start by opening a new issue describing the bug or
32+
feature you're intending to fix. Even if you think it's relatively minor,
33+
it's helpful to know what people are working on. Mention in the initial
34+
issue that you are planning to work on that bug or feature so that it can
35+
be assigned to you.
36+
37+
1. Follow the normal process of [forking][] the project, and setup a new
38+
branch to work in. It's important that each group of changes be done in
39+
separate branches in order to ensure that a pull request only includes the
40+
commits related to that bug or feature.
41+
42+
1. Do your best to have [well-formed commit messages][] with a [good
43+
description][] for each change. This provides consistency throughout
44+
the project, and ensures that commit messages are able to be formatted
45+
properly by various git tools.
46+
47+
1. Keep PRs [small and focused][] on a single issue. Do not make unrelated
48+
changes in the same PR "because you're there"; this includes reformatting
49+
of code, whether automatically or manually.
50+
51+
1. Finally, push the commits to your fork and submit a [pull request][].
52+
53+
[forking]: https://help.github.com/articles/fork-a-repo
54+
[well-formed commit messages]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
55+
[good description]: https://google.github.io/eng-practices/review/developer/cl-descriptions.html
56+
[pull request]: https://help.github.com/articles/creating-a-pull-request
57+
[small and focused]: https://google.github.io/eng-practices/review/developer/small-cls.html
58+
59+
60+
## Style ##
61+
62+
Contributions should follow the [Go Style Guide](https://google.github.io/styleguide/go). Code should be [formatted] with `gofmt`.

README.md

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ S2ConvexHull | ✅
195195
S2CrossingEdge | ✅
196196
S2HausdorffDistance | ❌
197197
S2ShapeNesting | ❌
198+
S2ValidationQuery | ❌
198199

199200
### Supporting Types
200201

@@ -203,32 +204,37 @@ C++ Type | Go
203204
S2BooleanOperation | ❌
204205
S2BufferOperation | ❌
205206
S2Builder | ❌
206-
S2BuilderClosedSetNormalizer | ❌
207-
S2BuilderFindPolygonDegeneracies | ❌
208207
S2BuilderGraph | ❌
209-
S2BuilderLayers | ❌
210-
S2BuilderSnapFunctions | ❌
211-
S2BuilderTesting | ❌
212-
S2Builderutil\* | ❌
208+
S2BuilderLayer | ❌
209+
S2BuilderUtil_\* | ❌
210+
S2CellIterator | ❌
211+
S2CellIteratorJoin | ❌
212+
S2CellRangeIterator | ❌
213213
S2Coder | ❌
214+
S2Earth | ❌
214215
S2EdgeClipping | ✅
215216
S2EdgeCrosser | ✅
216217
S2EdgeCrossings | ✅
217218
S2EdgeDistances | ✅
218219
S2EdgeTessellator | ✅
220+
S2Fractal | ❌
219221
S2LoopMeasures | ❌
220222
S2Measures | ✅
221223
S2MemoryTracker | ❌
222224
S2Metrics | ❌
223225
S2PointUtil | 🟡
226+
S2PointCompression | 🟡
224227
S2PolygonBuilder | ❌
225228
S2PolylineAlignment | ❌
226229
S2PolylineMeasures | ✅
227230
S2PolylineSimplifier | ❌
228231
S2Predicates | ✅
229232
S2Projections | ❌
230-
S2rectBounder | ❌
233+
S2Random | ❌
234+
S2RectBounder | ❌
235+
S2RegionSharder | ❌
231236
S2RegionTermIndexer | ❌
237+
S2ShapeIndexBufferedRegion | ❌
232238
S2ShapeIndexMeasures | ❌
233239
S2ShapeIndexUtil\* | 🟡
234240
S2ShapeMeasures | ❌
@@ -239,7 +245,13 @@ S2TextFormat | ✅
239245
S2WedgeRelations | ✅
240246
S2WindingOperation | ❌
241247

248+
242249
### Encode/Decode
243250

244251
Encoding and decoding of S2 types is fully implemented and interoperable with
245252
C++ and Java.
253+
254+
255+
## Disclaimer
256+
257+
This is not an official Google product.

0 commit comments

Comments
 (0)