Merge pull request #23 from gofiber/codex/find-and-fix-a-bug

🐛 fix: Default tag parsing

Author: ReneWerner87

.github/workflows/test.yml

@@ -15,7 +15,7 @@ jobs:
   unit:
     strategy:
       matrix:
-        go-version: [1.22.x, 1.23.x]
+        go-version: [1.22.x, 1.23.x, 1.24.x]
         platform: [ubuntu-latest, windows-latest, macos-latest, macos-13]
     runs-on: ${{ matrix.platform }}
     steps:
@@ -51,4 +51,4 @@ jobs:
           go-version: stable
 
       - name: Test
-        run: go run gotest.tools/gotestsum@latest -f testname -- ./... -race -count=15 -shuffle=on
+        run: go run gotest.tools/gotestsum@latest -f testname -- ./... -race -count=15 -shuffle=on

cache.go

@@ -310,9 +310,8 @@ func (o tagOptions) Contains(option string) bool {
 func (o tagOptions) getDefaultOptionValue() string {
 	for _, s := range o {
 		if strings.HasPrefix(s, "default:") {
-			return strings.Split(s, ":")[1]
+			return strings.SplitN(s, ":", 2)[1]
 		}
 	}
-
 	return ""
 }

decoder_test.go

@@ -2456,6 +2456,23 @@ func TestDefaultsAreNotSupportedForStructsAndStructSlices(t *testing.T) {
 	}
 }
 
+func TestDefaultValueWithColon(t *testing.T) {
+	t.Parallel()
+	type D struct {
+		URL string `schema:"url,default:http://localhost:8080"`
+	}
+
+	var d D
+	decoder := NewDecoder()
+	if err := decoder.Decode(&d, map[string][]string{}); err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+
+	if d.URL != "http://localhost:8080" {
+		t.Errorf("expected default url to be http://localhost:8080, got %s", d.URL)
+	}
+}
+
 func TestDecoder_MaxSize(t *testing.T) {
 	t.Parallel()