Make BitMap.create
and BitMap.create_from_image_alpha
static
#5808
Closed
dalexeev
started this conversation in
Engine Core
Replies: 3 comments 4 replies
-
@KoBeWi You may be interested in this. :) |
Beta Was this translation helpful? Give feedback.
0 replies
-
I agree, but this breaks compatibility, so it might be too late to change it. |
Beta Was this translation helpful? Give feedback.
4 replies
-
Let's defer this to Godot 5.0. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I noticed that the methods
Image.create
,Image.create_from_data
andImageTexture.create_from_image
became static (godotengine/godot#60739), whileBitMap.create
andBitMap.create_from_image_alpha
remained non-static.Although this trend can be treated differently, Godot is now moving more actively towards static methods (this is especially noticeable in
FileAccess
andDirAccess
, with their static methods duplicating non-static ones).And since
Image
,ImageTexture
, andBitMap
also belong to the same area, for consistency, we should make theBitMap.create*
methods also static (and add a non-static alternative forcreate_from_image_alpha
, so forcreate
there is an alternative in the form ofresize
orset_bit_rect
, but we can also addfill
).Beta Was this translation helpful? Give feedback.
All reactions