Add VisualInstance attribute to MeshLibrary items

[escapade-games]

This is a proposal created mainly to address issue #40245, which if solved would help my game immensely.

What I would like to propose is that we add a VisualInstance attribute to MeshLibrary items.

Currently, each MeshLibrary item only has the following attributes:

What I suggest is adding a VisualInstance attribute among them. Since we create MeshLibraries by converting a scene of MeshInstances, and MeshInstance already has the VisualInstance attribute, why not preserve the attribute when converting the scene to a MeshLibrary?

Not only would this solve the issue of all the GridMap tiles being visible only on cull_mask layer 1, but it also has the added flexibility of having different tiles in the same GridMap be visible on different VisualLayers.

I see that this would help not just me, but also many others facing this problem when using GridMaps, as evidenced from how this bug report was even made in the first place. Thus I hope you can consider this proposal.

[theraot]

Sounds like what you need is the layers property, not a VisualInstance per se. For reference VisualInstance is a base class for multiple nodes including MeshInstance. GridMap will be creating some VisualInstances for you (MultiMeshInstances actually). Thus, in theory it is a matter of copying the value along.