*cmp_to functions of the String class should be consolidated #5276
the-sink
started this conversation in
Engine Core
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
It feels kinda weird to me that there are two separate String comparison functions to change whether the comparison should be case sensitive or not (
casecmp_to
andnocasecmp_to
), and I thought it would be nice if these were consolidated into onecompare_to(*p_str, bool case_sensitive=false)
function. The non case-sensitive function appears to be used more often in the engine itself, and I would imagine this is the case for most projects as well, so case sensitivity should probably be off by default.I wasn't so sure about
naturalnocasecmp_to
though... Perhapsncompare_to
with the same case sensitivity option added?Beta Was this translation helpful? Give feedback.
All reactions