Skip to content

Decide whether to expose godot_char_string publicly #993

Open
@chitoyuu

Description

@chitoyuu

Created during survey of commented code (#377).

godot_char_string is a Godot string type representing a byte string of some encoding. It is currently used internally in the #[doc(hidden)] Utf8String type in the conversion process from GodotString to the Rust String.

Reasons we might want this type to become public (likely with a re-designed API):

  • Sake of completeness.
  • Beyond UTF8, Godot also exposes functions to create char_strings in ascii and ascii_extended encodings, that could be interesting.

Reasons we might want to remove it altogether in favor of inline FFI calls in conversion:

  • Extremely narrow API surface of the type that essentially consists of only a &[c_char] getter.

Metadata

Metadata

Assignees

No one assigned

    Labels

    c: coreComponent: core (mod core_types, object, log, init, ...)featureAdds functionality to the library

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions