Skip to content

Commit e2fc055

Browse files
bors[bot]banool
andauthored
Merge #676
676: Fix dynamic lib generation for rpc example r=toasteater a=banool In the example as provided, the dynamic lib file that gets generated is `target/debug/rpc.ext` (so `target/debug/rpc.dylib` on MacOS for example). This means when you try to follow the README in `examples/rpc`, it doesn't work, because it generates `rpc.dylib` instead of the file it expects in the gdnlib. This PR changes the gdnlib to expect the output to be called `rpc` instead (since it is based on the directory name). I also change the name of the gdnlib file to _library, to match the other examples. Co-authored-by: Daniel Porteous <danielporteous1@gmail.com>
2 parents 2b26788 + 61023fe commit e2fc055

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

examples/rpc/Server.gdns

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[gd_resource type="NativeScript" load_steps=2 format=2]
22

3-
[ext_resource path="res://client_server.gdnlib" type="GDNativeLibrary" id=1]
3+
[ext_resource path="res://client_server_library.gdnlib" type="GDNativeLibrary" id=1]
44

55
[resource]
66
resource_name = "Server"

examples/rpc/ServerPuppet.gdns

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[gd_resource type="NativeScript" load_steps=2 format=2]
22

3-
[ext_resource path="res://client_server.gdnlib" type="GDNativeLibrary" id=1]
3+
[ext_resource path="res://client_server_library.gdnlib" type="GDNativeLibrary" id=1]
44

55
[resource]
66
resource_name = "ServerPuppet"

examples/rpc/client_server.gdnlib

Lines changed: 0 additions & 17 deletions
This file was deleted.
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
[general]
2+
3+
singleton=false
4+
load_once=true
5+
symbol_prefix="godot_"
6+
reloadable=true
7+
8+
[entry]
9+
10+
X11.64="res://../../target/debug/librpc.so"
11+
OSX.64="res://../../target/debug/librpc.dylib"
12+
Windows.64="res://../../target/debug/rpc.dll"
13+
14+
[dependencies]
15+
16+
X11.64=[ ]
17+
OSX.64=[ ]

0 commit comments

Comments
 (0)