Merge #1016

1016: Remove specialized pool array aliases r=chitoyuu a=chitoyuu

These type aliases were deprecated in 0.11, and are now removed. Also in the process:

- Genericized access tests, reducing duplicate code.
- Removed tests of `Debug` formattings. The Debug representations of standard types aren't stablized, so these hard coded strings can break at any time. Additionally, the impl itself is trivial, so there isn't much benefit to be had from the tests in the first place.

Co-authored-by: Chitose Yuuzaki <chitoyuu@potatoes.gay>

Author: bors[bot]

check.sh

@@ -62,8 +62,8 @@ function findGodot() {
     fi
 }
 
-features="gdnative/async,gdnative/serde,gdnative/inventory"
-itest_toggled_features="no-manual-register"
+features="gdnative/async,gdnative/serde"
+itest_toggled_features="gdnative/inventory,no-manual-register"
 cmds=()
 
 for arg in "${args[@]}"; do

gdnative-core/src/core_types/byte_array.rs

@@ -8,45 +8,31 @@
 mod geom;
 
 mod access;
-mod byte_array;
 mod color;
-mod color_array;
 mod dictionary;
 mod error;
-mod float32_array;
-mod int32_array;
 mod node_path;
 mod pool_array;
 mod rid;
 mod string;
-mod string_array;
 mod variant;
 mod variant_array;
 mod vector2;
-mod vector2_array;
 mod vector3;
-mod vector3_array;
 
 pub use access::*;
-pub use byte_array::*;
 pub use color::*;
-pub use color_array::*;
 pub use dictionary::*;
 pub use error::{GodotError, GodotResult};
-pub use float32_array::*;
 pub use geom::*;
-pub use int32_array::*;
 pub use node_path::*;
 pub use pool_array::*;
 pub use rid::*;
 pub use string::*;
-pub use string_array::*;
 pub use variant::*;
 pub use variant_array::*;
 pub use vector2::*;
-pub use vector2_array::*;
 pub use vector3::*;
-pub use vector3_array::*;
 
 use approx::relative_eq;
 

gdnative-core/src/core_types/color_array.rs

@@ -8,6 +8,11 @@ use crate::core_types::{Color, GodotString, VariantArray, Vector2, Vector3};
 use crate::object::NewRef;
 use crate::private::get_api;
 
+#[cfg(feature = "gd-test")]
+mod godot_tests;
+#[cfg(feature = "gd-test")]
+pub use godot_tests::*;
+
 /// A RAII read access for Godot pool arrays.
 pub type Read<'a, T> = Aligned<ReadGuard<'a, T>>;
 
@@ -68,15 +73,14 @@ impl<T: PoolElement> PoolArray<T> {
     ///
     /// For example:
     /// ```no_run
-    /// // Int32Array is a type alias for PoolArray<i32>
-    /// use gdnative::core_types::Int32Array;
+    /// use gdnative::core_types::PoolArray;
     ///
     /// // Collect from range
-    /// let arr = (0..4).collect::<Int32Array>();
+    /// let arr = (0i32..4).collect::<PoolArray<_>>();
     ///
     /// // Type conversion
     /// let vec: Vec<u32> = vec![1, 1, 2, 3, 5]; // note: unsigned
-    /// let arr = vec.iter().map(|&e| e as i32).collect::<Int32Array>();
+    /// let arr = vec.iter().map(|&e| e as i32).collect::<PoolArray<_>>();
     /// ```
     #[inline]
     pub fn from_vec(mut src: Vec<T>) -> Self {