Skip to content

Commit 555cdcd

Browse files
bors[bot]chitoyuu
andauthored
Merge #800
800: Re-export `gdnative_core::log` again r=Bromeon a=chitoyuu Types and functions in the `log` module should remain visible and part of the public API: - `Site` is the return type of the trait method `Method::site`, and is necessary to name when implementing the trait manually e.g. for a generic method. - `print`, `warn` and `error` are safe high-level bindings to the native logging facilities that aren't available elsewhere, and are worthwhile to expose for custom `log` backend implementations that want to use call site information from the logging framework instead. Co-authored-by: Chitose Yuuzaki <chitoyuu@potatoes.gay>
2 parents e74c573 + adc6b2b commit 555cdcd

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

gdnative-core/src/lib.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ pub mod core_types;
4545
#[cfg(feature = "nativescript")]
4646
pub mod nativescript;
4747

48-
#[doc(hidden)]
4948
pub mod log;
5049
pub mod object;
5150

gdnative/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
// Items, which are #[doc(hidden)] in their original crate and re-exported with a wildcard, lose
5959
// their hidden status. Re-exporting them manually and hiding the wildcard solves this.
6060
#[doc(inline)]
61-
pub use gdnative_core::{core_types, nativescript, object};
61+
pub use gdnative_core::{core_types, log, nativescript, object};
6262

6363
/// Collection of declarative `godot_*` macros, mostly for GDNative registration and output.
6464
pub mod macros {

0 commit comments

Comments
 (0)