Simplify value-iteration over arrays

Also simplifies a few other iterations.

Arrays did not implement IntoIterator until Rust 1.56:
https://doc.rust-lang.org/edition-guide/rust-2021/IntoIterator-for-arrays.html

Author: Bromeon

bindings-generator/src/classes.rs

@@ -76,7 +76,7 @@ pub(crate) fn generate_class_constants(class: &GodotClass) -> TokenStream {
         class.constants.iter().collect();
     class_constants.sort_by(constant_sorter);
 
-    for (name, value) in &class_constants {
+    for (name, value) in class_constants {
         let name = format_ident!("{}", name);
         let constant = quote! {
             pub const #name: i64 = #value;

bindings-generator/src/godot_version.rs

@@ -54,15 +54,15 @@ fn test_godot_versions() {
     ];
 
     // From Rust 1.56: 'for (...) in good_versions'
-    for (full, major, minor, patch, stability) in good_versions.iter().cloned() {
+    for (full, major, minor, patch, stability) in good_versions {
         let parsed: GodotVersion = parse_godot_version(full).unwrap();
         assert_eq!(parsed.major, major);
         assert_eq!(parsed.minor, minor);
         assert_eq!(parsed.patch, patch);
         assert_eq!(parsed.stability, stability);
     }
 
-    for full in bad_versions.iter() {
+    for full in bad_versions {
         let parsed = parse_godot_version(full);
         assert!(parsed.is_err());
     }

bindings-generator/src/lib.rs

@@ -225,7 +225,7 @@ pub(crate) mod test_prelude {
 
         let api = Api::new(include_str!("../../gdnative-bindings/api.json"));
         let mut buffer = BufWriter::new(Vec::with_capacity(16384));
-        for class in &api.classes {
+        for class in api.classes {
             let mut icalls = HashMap::new();
 
             let code = generate_module_doc(&class);

gdnative-derive/src/native_script.rs

@@ -287,7 +287,7 @@ fn parse_derive_input(input: &DeriveInput) -> Result<DeriveData, syn::Error> {
                         let attr_args_builder = property_args
                             .get_or_insert_with(|| PropertyAttrArgsBuilder::new(&field.ty));
 
-                        for arg in &nested {
+                        for arg in nested {
                             if let NestedMeta::Meta(Meta::NameValue(ref pair)) = arg {
                                 attr_args_builder.add_pair(pair)?;
                             } else if let NestedMeta::Meta(Meta::Path(ref path)) = arg {
@@ -473,9 +473,9 @@ mod tests {
             (attr_getp_setp, true, true),
         ];
 
-        for (attr, allowed_bare, allowed_property) in &combinations {
-            check_property_combination(attr, quote! { i32 }, *allowed_bare);
-            check_property_combination(attr, quote! { Property<i32> }, *allowed_property);
+        for (attr, allowed_bare, allowed_property) in combinations {
+            check_property_combination(&attr, quote! { i32 }, allowed_bare);
+            check_property_combination(&attr, quote! { Property<i32> }, allowed_property);
         }
     }
 

gdnative-derive/src/varargs.rs

@@ -48,7 +48,7 @@ pub(crate) fn derive_from_varargs(input: DeriveInput) -> Result<TokenStream2, sy
 
         let mut required = Vec::new();
         let mut optional = Vec::new();
-        for field in fields.iter() {
+        for field in fields {
             let is_optional = field.attrs.iter().any(|attr| attr.path.is_ident("opt"));
             if !is_optional && !optional.is_empty() {
                 return Err(syn::Error::new(