More examples in Vector2/Vector3 angle tests

Author: Bromeon

itest/rust/src/builtin_tests/geometry/vector_test/vector2_test.rs

@@ -7,13 +7,10 @@
 
 use crate::framework::itest;
 
-use godot::builtin::{
-    inner::InnerVector2,
-    math::{assert_eq_approx, ApproxEq},
-    real,
-    real_consts::PI,
-    Vector2, Vector2Axis,
-};
+use godot::builtin::inner::InnerVector2;
+use godot::builtin::math::{assert_eq_approx, ApproxEq};
+use godot::builtin::real_consts::{FRAC_PI_2, PI};
+use godot::builtin::{real, Vector2, Vector2Axis};
 
 #[itest]
 fn abs() {
@@ -25,8 +22,16 @@ fn abs() {
 #[itest]
 fn angle() {
     let a = Vector2::new(1.2, -3.4);
+    let b = Vector2::new(-5.6, 7.8);
 
     assert_eq!(a.angle(), a.as_inner().angle() as real);
+    assert_eq!(b.angle(), b.as_inner().angle() as real);
+
+    // Check direction (note: DOWN=(0, 1)).
+    assert_eq_approx!(Vector2::RIGHT.angle(), 0.0);
+    assert_eq_approx!(Vector2::DOWN.angle(), FRAC_PI_2);
+    assert_eq_approx!(Vector2::LEFT.angle(), PI);
+    assert_eq_approx!(Vector2::UP.angle(), -FRAC_PI_2);
 }
 
 #[itest]
@@ -35,6 +40,11 @@ fn angle_to() {
     let b = Vector2::new(-5.6, 7.8);
 
     assert_eq_approx!(a.angle_to(b), a.as_inner().angle_to(b) as real);
+    assert_eq_approx!(b.angle_to(a), b.as_inner().angle_to(a) as real);
+
+    // Check direction (note: DOWN=(0, 1)).
+    assert_eq_approx!(Vector2::RIGHT.angle_to(Vector2::DOWN), FRAC_PI_2);
+    assert_eq_approx!(Vector2::DOWN.angle_to(Vector2::RIGHT), -FRAC_PI_2);
 }
 
 #[itest]
@@ -43,6 +53,17 @@ fn angle_to_point() {
     let b = Vector2::new(-5.6, 7.8);
 
     assert_eq!(a.angle_to_point(b), a.as_inner().angle_to_point(b) as real);
+    assert_eq!(b.angle_to_point(a), b.as_inner().angle_to_point(a) as real);
+
+    // Check absolute value.
+    assert_eq_approx!(
+        Vector2::new(1.0, 1.0).angle_to_point(Vector2::new(1.0, 2.0)),
+        FRAC_PI_2
+    ); // up
+    assert_eq_approx!(
+        Vector2::new(1.0, 1.0).angle_to_point(Vector2::new(1.0, -1.0)),
+        -FRAC_PI_2
+    ); // down
 }
 
 #[itest]

itest/rust/src/builtin_tests/geometry/vector_test/vector3_test.rs

@@ -7,13 +7,11 @@
 
 use crate::framework::itest;
 
-use godot::builtin::{
-    inner::InnerVector3,
-    math::{assert_eq_approx, ApproxEq},
-    real,
-    real_consts::PI,
-    Vector3, Vector3Axis,
-};
+use godot::builtin::inner::InnerVector3;
+use godot::builtin::math::{assert_eq_approx, ApproxEq};
+use godot::builtin::real;
+use godot::builtin::real_consts::{FRAC_PI_4, PI};
+use godot::builtin::{Vector3, Vector3Axis};
 
 #[itest]
 fn abs() {
@@ -28,6 +26,36 @@ fn angle_to() {
     let b = Vector3::new(-7.8, 9.1, -11.12);
 
     assert_eq_approx!(a.angle_to(b), a.as_inner().angle_to(b) as real);
+
+    // Concrete example (135°).
+    let right = Vector3::new(1.0, 0.0, 0.0);
+    let back_left = Vector3::new(-1.0, 0.0, 1.0);
+
+    assert_eq_approx!(right.angle_to(back_left), 3.0 * FRAC_PI_4);
+    assert_eq_approx!(back_left.angle_to(right), 3.0 * FRAC_PI_4);
+}
+
+#[itest]
+fn signed_angle_to() {
+    let a = Vector3::new(1.0, 1.0, 0.0);
+    let b = Vector3::new(1.0, 1.0, 1.0);
+    let c = Vector3::UP;
+
+    assert_eq_approx!(
+        a.signed_angle_to(b, c),
+        a.as_inner().signed_angle_to(b, c) as real,
+        "signed_angle_to\n",
+    );
+
+    // Concrete example (135°).
+    let right = Vector3::new(1.0, 0.0, 0.0);
+    let back_left = Vector3::new(-1.0, 0.0, 1.0);
+
+    let pi_3_4 = 3.0 * FRAC_PI_4;
+    assert_eq_approx!(right.signed_angle_to(back_left, Vector3::UP), -pi_3_4);
+    assert_eq_approx!(right.signed_angle_to(back_left, Vector3::DOWN), pi_3_4);
+    assert_eq_approx!(back_left.signed_angle_to(right, Vector3::UP), pi_3_4);
+    assert_eq_approx!(back_left.signed_angle_to(right, Vector3::DOWN), -pi_3_4);
 }
 
 #[itest]
@@ -402,19 +430,6 @@ fn sign() {
     assert_eq!(b.sign(), b.as_inner().sign());
 }
 
-#[itest]
-fn signed_angle_to() {
-    let a = Vector3::new(1.0, 1.0, 0.0);
-    let b = Vector3::new(1.0, 1.0, 1.0);
-    let c = Vector3::UP;
-
-    assert_eq_approx!(
-        a.signed_angle_to(b, c),
-        a.as_inner().signed_angle_to(b, c) as real,
-        "signed_angle_to\n",
-    );
-}
-
 #[itest]
 fn slerp() {
     let a = Vector3::new(1.2, -3.4, 5.6);