Fix Clippy issues in register-docs gated code

Author: Bromeon

godot-core/src/docs.rs

@@ -89,6 +89,7 @@ pub fn gather_xml_docs() -> impl Iterator<Item = String> {
             PluginItem::Struct {
                 docs: Some(docs), ..
             } => map.entry(class_name).or_default().definition = docs,
+
             _ => (),
         }
     });

godot-macros/src/docs.rs

@@ -21,7 +21,7 @@ pub fn make_definition_docs(
         let base_escaped = xml_escape(base);
         let desc_escaped = xml_escape(make_docs_from_attributes(description)?);
         let members = members
-            .into_iter()
+            .iter()
             .filter(|x| x.var.is_some() | x.export.is_some())
             .filter_map(member)
             .collect::<String>();
@@ -112,7 +112,7 @@ fn siphon_docs_from_attributes(doc: &[Attribute]) -> impl Iterator<Item = String
             _ => None,
         })
         .flat_map(|doc| {
-            doc.into_iter().map(|x| {
+            doc.iter().map(|x| {
                 x.to_string()
                     .trim_start_matches('r')
                     .trim_start_matches('#')
@@ -126,7 +126,7 @@ fn siphon_docs_from_attributes(doc: &[Attribute]) -> impl Iterator<Item = String
 
 fn xml_escape(value: String) -> String {
     // Most strings have no special characters, so this check helps avoid unnecessary string copying
-    if !value.contains(&['&', '<', '>', '"', '\'']) {
+    if !value.contains(['&', '<', '>', '"', '\'']) {
         return value;
     }
 

godot-macros/src/docs/markdown_converter.rs

@@ -79,7 +79,7 @@ fn walk_node(node: &md::Node, definitions: &HashMap<&str, &str>) -> Option<Strin
 
         Html(html) => html.value.clone(),
 
-        _ => walk_nodes(&node.children()?, definitions, ""),
+        _ => walk_nodes(node.children()?, definitions, ""),
     };
 
     Some(bbcode)

itest/rust/src/register_tests/constant_test.rs

@@ -174,7 +174,7 @@ godot::sys::plugin_add!(
                 raw: ::godot::private::callbacks::register_user_methods_constants::<HasOtherConstants>,
             },
             register_rpcs_fn: None,
-            #[cfg(all(since_api = "4.3", feature = "register-docs"))]
+            #[cfg(feature = "register-docs")]
             docs: ::godot::docs::InherentImplDocs::default(),
         }),
         init_level: HasOtherConstants::INIT_LEVEL,