Refactor get_builtin_arg_passing() to use Godot type name

Author: Bromeon

godot-codegen/src/context.rs

@@ -243,14 +243,14 @@ impl<'a> Context<'a> {
         self.builtin_types.contains(ty_name)
     }
 
-    pub fn get_builtin_arg_passing(&self, ty_name: &str) -> ArgPassing {
+    pub fn get_builtin_arg_passing(&self, godot_ty: &GodotTy) -> ArgPassing {
         // Already handled separately.
-        debug_assert!(!ty_name.starts_with("Packed"));
+        debug_assert!(!godot_ty.ty.starts_with("Packed"));
 
         // Arrays are also handled separately, and use ByRef.
-        match ty_name {
-            "Variant" | "VariantArray" | "Dictionary" => ArgPassing::ByRef,
-            "GString" | "NodePath" | "StringName" => ArgPassing::ImplAsArg,
+        match godot_ty.ty.as_str() {
+            "Variant" | "Array" | "Dictionary" => ArgPassing::ByRef,
+            "String" | "StringName" | "NodePath" => ArgPassing::ImplAsArg,
             _ => ArgPassing::ByValue,
         }
     }

godot-codegen/src/conv/type_conversions.rs

@@ -179,7 +179,7 @@ fn to_rust_type_uncached(full_ty: &GodotTy, ctx: &mut Context) -> RustTy {
         if let Some(hardcoded) = to_hardcoded_rust_ident(full_ty) {
             return RustTy::BuiltinIdent {
                 ty: ident(hardcoded),
-                arg_passing: ctx.get_builtin_arg_passing(hardcoded),
+                arg_passing: ctx.get_builtin_arg_passing(full_ty),
             };
         }
     }
@@ -224,7 +224,7 @@ fn to_rust_type_uncached(full_ty: &GodotTy, ctx: &mut Context) -> RustTy {
         // Native structures might not all be Copy, but they should have value semantics.
         RustTy::BuiltinIdent {
             ty: rustify_ty(ty),
-            arg_passing: ctx.get_builtin_arg_passing(ty),
+            arg_passing: ctx.get_builtin_arg_passing(full_ty),
         }
     } else {
         let ty = rustify_ty(ty);

godot-core/src/builtin/variant/impls.rs

@@ -130,8 +130,10 @@ macro_rules! impl_ffi_variant {
 #[allow(clippy::module_inception)]
 mod impls {
     use super::*;
+    
+    // IMPORTANT: the presence/absence of `ref` here should be aligned with the ArgPassing variant
+    // used in codegen get_builtin_arg_passing().
 
-    // Also implements ArrayType.
     impl_ffi_variant!(bool, bool_to_variant, bool_from_variant);
     impl_ffi_variant!(i64, int_to_variant, int_from_variant; int);
     impl_ffi_variant!(f64, float_to_variant, float_from_variant; float);