Skip to content

Commit 818508e

Browse files
committed
CI: update LLVM from 10.0 to 15.0.7 -> fix spurious macOS failures
Fixes an issue where macOS CI spuriously failed, because it could not read the Godot version (or invoke the Rust Command API on Godot in general). Trying to look for the issue in all sorts of dimensions (Godot version, rustc version, gdext's own config changes), it turned out that LLVM was the only thing that could sustainably address it. Which is also a bit strange, since v10.0 has not caused issues before, only since around start of October 2023. If it reappears, one more thing to look into would be versions of GitHub actions (that are not locked, but auto-updated).
1 parent 41ce77f commit 818508e

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

.github/composite/llvm/action.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
name: llvm
66
description: "Install LLVM + Clang, with caching"
77

8-
#inputs:
9-
# llvm:
10-
# required: false
11-
# default: 'true'
12-
# description: "Whether LLVM should be installed ('true' by default)"
8+
inputs:
9+
llvm-version:
10+
required: false
11+
default: '15.0.7'
12+
description: "LLVM versions. Greater than 15 may not be supported in all runners."
1313

1414
runs:
1515
using: "composite"
@@ -31,12 +31,13 @@ runs:
3131
# C:/Program Files/LLVM
3232
# ./llvm
3333
path: ${{ env.LLVM_INSTALL_DIR }}
34-
key: llvm-10.0
34+
key: "llvm-${{ inputs.llvm-version }}"
3535

3636
- uses: KyleMayes/install-llvm-action@v1
3737
# if: inputs.llvm == 'true'
3838
with:
39-
version: "10.0"
39+
# Newer versions failed on macOS with "Unsupported target! (platform='darwin', version='17.0.2')"
40+
version: "${{ inputs.llvm-version }}"
4041
directory: ${{ env.LLVM_INSTALL_DIR }}
4142
cached: ${{ steps.cache-llvm.outputs.cache-hit }}
4243

0 commit comments

Comments
 (0)