Skip to content

Commit 68610a3

Browse files
committed
Rename 2 OpenXR classes for readability
1 parent 3234344 commit 68610a3

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

godot-codegen/src/tests.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ fn test_pascal_conversion() {
3131
("JSONRPC", "JsonRpc"),
3232
("NetworkedMultiplayerENet", "NetworkedMultiplayerENet"),
3333
("ObjectID", "ObjectId"),
34+
("OpenXRAPIExtension", "OpenXrApiExtension"),
35+
("OpenXRIPBinding", "OpenXrIpBinding"),
3436
("PackedFloat32Array", "PackedFloat32Array"),
3537
("PCKPacker", "PckPacker"),
3638
("PHashTranslation", "PHashTranslation"),
@@ -77,6 +79,8 @@ fn test_snake_conversion() {
7779
("JSONRPC", "json_rpc"),
7880
("NetworkedMultiplayerENet", "networked_multiplayer_e_net"),
7981
("ObjectID", "object_id"),
82+
("OpenXRAPIExtension", "open_xr_api_extension"),
83+
("OpenXRIPBinding", "open_xr_ip_binding"),
8084
("PackedFloat32Array", "packed_float32_array"),
8185
("PCKPacker", "pck_packer"),
8286
("PHashTranslation", "p_hash_translation"),

godot-codegen/src/util.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -431,9 +431,10 @@ pub fn to_snake_case(class_name: &str) -> String {
431431
use heck::ToSnakeCase;
432432

433433
// Special cases
434-
#[allow(clippy::single_match)]
435434
match class_name {
436435
"JSONRPC" => return "json_rpc".to_string(),
436+
"OpenXRAPIExtension" => return "open_xr_api_extension".to_string(),
437+
"OpenXRIPBinding" => return "open_xr_ip_binding".to_string(),
437438
_ => {}
438439
}
439440

@@ -448,10 +449,11 @@ pub fn to_snake_case(class_name: &str) -> String {
448449
pub fn to_pascal_case(class_name: &str) -> String {
449450
use heck::ToPascalCase;
450451

451-
// Special cases
452-
#[allow(clippy::single_match)]
452+
// Special cases: reuse snake_case impl to ensure at least consistency between those 2.
453453
match class_name {
454-
"JSONRPC" => return "JsonRpc".to_string(),
454+
"JSONRPC" | "OpenXRAPIExtension" | "OpenXRIPBinding" => {
455+
return to_snake_case(class_name).to_pascal_case()
456+
}
455457
_ => {}
456458
}
457459

0 commit comments

Comments
 (0)